Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Move apt recipe requirement to install from package #61

Merged
merged 1 commit into from

2 participants

@ratdaddy

The apt recipe is only required when installing from a package (and for Debian-flavored platforms) so it should only appear in the install_from_package recipe. Also, the README is a bit off in that it should call out the yum requirement and it would be nice if it mentioned that build-essential is only needed when installing from source and apt/yum are only needed when installing from a package.

@mdxp mdxp merged commit 0c18f7b into mdxp:master
@mdxp
Owner

Merged! Thanks @ratdaddy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
4 README.md
@@ -16,8 +16,8 @@ REQUIREMENTS
## Cookbooks:
-* build-essential
-* apt
+* build-essential (when installing from source)
+* apt or yum (when installing from package)
Opscode cookbooks (http://github.com/opscode/cookbooks/tree/master)
View
4 recipes/default.rb
@@ -17,9 +17,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-case node['platform_family']
- when "debian"
- include_recipe "apt"
-end
include_recipe "nodejs::install_from_#{node['nodejs']['install_method']}"
View
1  recipes/install_from_package.rb
@@ -22,6 +22,7 @@
case node['platform_family']
when 'debian'
+ include_recipe "apt"
if node['nodejs']['legacy_packages'] == true
repo = 'http://ppa.launchpad.net/chris-lea/node.js-legacy/ubuntu'
packages = %w{ nodejs npm }
Something went wrong with that request. Please try again.