adds create_if_missing to remote file action #8

Merged
merged 1 commit into from Aug 14, 2012

Conversation

Projects
None yet
3 participants
@videlalvaro
Contributor

videlalvaro commented Jul 25, 2012

at the moment the source recipe was downloading nodejs source all the time. With this change is just downloaded the first time

adds create_if_missing to remote file action
at the moment the source recipe was downloading nodejs source all the time. With this change is just downloaded the first time
@mdxp

This comment has been minimized.

Show comment Hide comment
@mdxp

mdxp Aug 14, 2012

Owner

@videlalvaro thanks for the patch. Still, this should not be necessary as remote_file will do this by default. The only reason when this could happen is either if you have the wrong checksum for the file or there is some bug in chef. Can you pls. double-check that or let me know what version of node and what checksum you are using? Thx!

Owner

mdxp commented Aug 14, 2012

@videlalvaro thanks for the patch. Still, this should not be necessary as remote_file will do this by default. The only reason when this could happen is either if you have the wrong checksum for the file or there is some bug in chef. Can you pls. double-check that or let me know what version of node and what checksum you are using? Thx!

@JulesAU

This comment has been minimized.

Show comment Hide comment
@JulesAU

JulesAU Aug 14, 2012

Contributor

Seems necessary to me - node 0.8.2 here, chef 0.10.8, always re-downloads:

[Tue, 14 Aug 2012 10:43:07 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] checking for changes
[Tue, 14 Aug 2012 10:43:07 +0000] DEBUG: Sending HTTP Request via GET to nodejs.org:80/dist/v0.8.2/node-v0.8.2.tar.gz
[Tue, 14 Aug 2012 10:43:07 +0000] DEBUG: Streaming download from http://nodejs.org/dist/v0.8.2/node-v0.8.2.tar.gz to tempfile /tmp/chef-rest20120814-11218-19gxyqs-0
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] checking for file existence of /usr/local/src/node-v0.8.2.tar.gz
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] file exists at /usr/local/src/node-v0.8.2.tar.gz
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] target checksum: 6830ed4eaf6c191243fb3afbe3ca3283d7e3a537c8f3ce508fa2af1328fe4baf
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] source checksum: 6830ed4eaf6c191243fb3afbe3ca3283d7e3a537c8f3ce508fa2af1328fe4baf
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] target and source checksums are the same - not updating
Contributor

JulesAU commented Aug 14, 2012

Seems necessary to me - node 0.8.2 here, chef 0.10.8, always re-downloads:

[Tue, 14 Aug 2012 10:43:07 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] checking for changes
[Tue, 14 Aug 2012 10:43:07 +0000] DEBUG: Sending HTTP Request via GET to nodejs.org:80/dist/v0.8.2/node-v0.8.2.tar.gz
[Tue, 14 Aug 2012 10:43:07 +0000] DEBUG: Streaming download from http://nodejs.org/dist/v0.8.2/node-v0.8.2.tar.gz to tempfile /tmp/chef-rest20120814-11218-19gxyqs-0
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] checking for file existence of /usr/local/src/node-v0.8.2.tar.gz
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] file exists at /usr/local/src/node-v0.8.2.tar.gz
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] target checksum: 6830ed4eaf6c191243fb3afbe3ca3283d7e3a537c8f3ce508fa2af1328fe4baf
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] source checksum: 6830ed4eaf6c191243fb3afbe3ca3283d7e3a537c8f3ce508fa2af1328fe4baf
[Tue, 14 Aug 2012 10:43:15 +0000] DEBUG: remote_file[/usr/local/src/node-v0.8.2.tar.gz] target and source checksums are the same - not updating

mdxp added a commit that referenced this pull request Aug 14, 2012

Merge pull request #8 from videlalvaro/patch-1
adds create_if_missing to remote file action

@mdxp mdxp merged commit 51a2c2a into mdxp:master Aug 14, 2012

@mdxp

This comment has been minimized.

Show comment Hide comment
@mdxp

mdxp Aug 14, 2012

Owner

I see what you mean. I have merged this. Thanks again for submitting the fix.

Owner

mdxp commented Aug 14, 2012

I see what you mean. I have merged this. Thanks again for submitting the fix.

@videlalvaro

This comment has been minimized.

Show comment Hide comment
@videlalvaro

videlalvaro Aug 23, 2012

Contributor

Thanks for merging this. I was in holidays so I couldn't reply

Contributor

videlalvaro commented Aug 23, 2012

Thanks for merging this. I was in holidays so I couldn't reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment