Repository navigation
using string-based secrets for easier debugging and help with issue v… - #30
Merged
Merged
Conversation
…alidating macaroons on ocaml with a binary-based secret
Contributor
|
Could you turn on allow edits from maintainers real quick? |
Contributor
|
Summary of @jptmoore's changes: secrets are alphanumeric now instead of random bytes, and made longer to account for lost entropy. This is because of a currently unknown incompatibility between |
Collaborator
Author
|
As discussed it might be worth removing the 2 step process of generating a secret then base64 encoding it to just generating something that can be transferred directly. |
This was referenced Jul 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…alidating macaroons on ocaml with a binary-based secret