New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using string-based secrets for easier debugging and help with issue v… #30

Merged
merged 5 commits into from Jul 26, 2017

Conversation

Projects
None yet
2 participants
@jptmoore
Contributor

jptmoore commented Jul 26, 2017

…alidating macaroons on ocaml with a binary-based secret

using string-based secrets for easier debugging and help with issue v…
…alidating macaroons on ocaml with a binary-based secret

@ghost ghost added the in progress label Jul 26, 2017

@yousefamar

This comment has been minimized.

Show comment
Hide comment
@yousefamar

yousefamar Jul 26, 2017

Contributor

Could you turn on allow edits from maintainers real quick?

Contributor

yousefamar commented Jul 26, 2017

Could you turn on allow edits from maintainers real quick?

@yousefamar

This comment has been minimized.

Show comment
Hide comment
@yousefamar

yousefamar Jul 26, 2017

Contributor

Summary of @jptmoore's changes: secrets are alphanumeric now instead of random bytes, and made longer to account for lost entropy. This is because of a currently unknown incompatibility between macaroons.js and ocaml-macaroons where one or the other encodes/decodes secrets differently (different charsets or so?) for the macaroon signing step, so this removes any ambiguity. @sevenEng, have you ever come across something like this before by any chance?

Contributor

yousefamar commented Jul 26, 2017

Summary of @jptmoore's changes: secrets are alphanumeric now instead of random bytes, and made longer to account for lost entropy. This is because of a currently unknown incompatibility between macaroons.js and ocaml-macaroons where one or the other encodes/decodes secrets differently (different charsets or so?) for the macaroon signing step, so this removes any ambiguity. @sevenEng, have you ever come across something like this before by any chance?

@yousefamar yousefamar merged commit af244c6 into me-box:master Jul 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ghost ghost removed the in progress label Jul 26, 2017

@jptmoore

This comment has been minimized.

Show comment
Hide comment
@jptmoore

jptmoore Jul 26, 2017

Contributor

As discussed it might be worth removing the 2 step process of generating a secret then base64 encoding it to just generating something that can be transferred directly.

Contributor

jptmoore commented Jul 26, 2017

As discussed it might be worth removing the 2 step process of generating a secret then base64 encoding it to just generating something that can be transferred directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment