Skip to content

using string-based secrets for easier debugging and help with issue v… - #30

Merged
yousefamar merged 5 commits into
me-box:masterfrom
jptmoore:string-secret
Jul 26, 2017
Merged

yousefamar merged 5 commits into
me-box:masterfrom
jptmoore:string-secret

Conversation

@jptmoore

Copy link
Copy Markdown
Collaborator

…alidating macaroons on ocaml with a binary-based secret

…alidating macaroons on ocaml with a binary-based secret
@ghost ghost added the in progress label Jul 26, 2017
@yousefamar

Copy link
Copy Markdown
Contributor

Could you turn on allow edits from maintainers real quick?

@yousefamar

Copy link
Copy Markdown
Contributor

Summary of @jptmoore's changes: secrets are alphanumeric now instead of random bytes, and made longer to account for lost entropy. This is because of a currently unknown incompatibility between macaroons.js and ocaml-macaroons where one or the other encodes/decodes secrets differently (different charsets or so?) for the macaroon signing step, so this removes any ambiguity. @sevenEng, have you ever come across something like this before by any chance?

@yousefamar
yousefamar merged commit af244c6 into me-box:master Jul 26, 2017
@ghost ghost removed the in progress label Jul 26, 2017
@jptmoore

Copy link
Copy Markdown
Collaborator Author

As discussed it might be worth removing the 2 step process of generating a secret then base64 encoding it to just generating something that can be transferred directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants