Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Undo breaking bugfix and honour suggested secret length #31
My original "bug fix" wasn't actually a bug fix. Also instead of an arbitrary 128 for length, this will make it so that
The alphanumeric character space is 62 characters, the base64 character space is 64 characters (with
As @jptmoore mentioned, now that the secrets have safe characters, we can completely make away with the base64 encoding/decoding step. This would be API-breaking however and would require updates to all stores.