New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base64 encoding of store secrets #33

Merged
merged 3 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@yousefamar
Contributor

yousefamar commented Jul 27, 2017

It turns out that the mystery incompatibility in handling macaroons between Node.js and OCaml from #30, was that the macaroons.js can accept secrets as either utf-8 strings or Buffers, with Buffers being more efficient. The arbiter was minting macaroons with Buffers, which results in distinct signatures than with strings, even if it's the same bytes as the lib's code shows.

Since ocaml-macaroons deals with strings, the past changes switched to string secrets. This inadvertently broke store-json. @Toshbrown remedied this by moving that also to strings in me-box-archive/store-json#6. And since we're modifying that, we took the opportunity to close #32 too. With that change, all is well in the world, and the new ocaml store also doesn't need to base64 decode anything.

@yousefamar yousefamar requested review from jptmoore and Toshbrown Jul 27, 2017

@ghost ghost added the in progress label Jul 27, 2017

@Toshbrown Toshbrown merged commit da67a25 into me-box:master Jul 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ghost ghost removed the in progress label Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment