New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name #22

Merged
merged 2 commits into from Jul 13, 2017

Conversation

Projects
None yet
2 participants
@Toshbrown
Contributor

Toshbrown commented Jul 13, 2017

@sevenEng can you check I've not missed anything before merging

Cheers

Tosh

@Toshbrown Toshbrown requested a review from sevenEng Jul 13, 2017

@sevenEng

This comment has been minimized.

Show comment
Hide comment
@sevenEng

sevenEng Jul 13, 2017

Contributor

That shoud be all in the running code.

But I'm wondering if worth also changing the names in build/config/distribute files too, eg:

https://github.com/me-box/core-export-service/blob/master/Dockerfile#L16
https://github.com/me-box/core-export-service/blob/master/pkg/pkg.ml#L7

and others, and If we are changing those too, shoud I change databox-export-service to core-export-service or export-service?

Contributor

sevenEng commented Jul 13, 2017

That shoud be all in the running code.

But I'm wondering if worth also changing the names in build/config/distribute files too, eg:

https://github.com/me-box/core-export-service/blob/master/Dockerfile#L16
https://github.com/me-box/core-export-service/blob/master/pkg/pkg.ml#L7

and others, and If we are changing those too, shoud I change databox-export-service to core-export-service or export-service?

@Toshbrown

This comment has been minimized.

Show comment
Hide comment
@Toshbrown

Toshbrown Jul 13, 2017

Contributor

Looking at those I'd go with export-service

Contributor

Toshbrown commented Jul 13, 2017

Looking at those I'd go with export-service

@sevenEng

This comment has been minimized.

Show comment
Hide comment
@sevenEng

sevenEng Jul 13, 2017

Contributor

That should be all.

Contributor

sevenEng commented Jul 13, 2017

That should be all.

@Toshbrown Toshbrown merged commit d576ad7 into master Jul 13, 2017

@sevenEng sevenEng deleted the renameing branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment