New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update main databox repo documentation #113

Merged
merged 9 commits into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@Toshbrown
Contributor

Toshbrown commented Sep 27, 2017

Contributes to: #102

Add Link to CONTRIBUTING.md
And fix some formatting

@Toshbrown Toshbrown requested a review from pooyadav Sep 27, 2017

@Toshbrown Toshbrown requested a review from mor1 Sep 27, 2017

@pooyadav

This comment has been minimized.

Show comment
Hide comment
@pooyadav

pooyadav Sep 27, 2017

Contributor

I think this would go in documents.

Contributor

pooyadav commented Sep 27, 2017

I think this would go in documents.

@pooyadav

There are few typos - also I feel it should go in documents ( as we have all documents are there) and readme.md should be updated accordingly

@Toshbrown

This comment has been minimized.

Show comment
Hide comment
@Toshbrown

Toshbrown Sep 27, 2017

Contributor

I'm happy for these to be moved (though it is the convention to have them here).

Contributor

Toshbrown commented Sep 27, 2017

I'm happy for these to be moved (though it is the convention to have them here).

Show outdated Hide outdated CONTRIBUTING.md
Show outdated Hide outdated CONTRIBUTING.md
@mor1

Were these versions of files substantially copied from anywhere? If so, please check licensing and do the appropriate things.

CONTRIBUTING.md traditionally goes in the root dir of project (along with a few other things).

Show outdated Hide outdated README.md
Show outdated Hide outdated TESTING.md

Toshbrown added some commits Oct 5, 2017

@Toshbrown Toshbrown merged commit fe61daa into master Oct 6, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details

@Toshbrown Toshbrown deleted the 102-updateDocs branch Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment