New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

131 dev build changes #132

Merged
merged 15 commits into from Oct 9, 2017

Conversation

Projects
None yet
5 participants
@Toshbrown
Contributor

Toshbrown commented Oct 6, 2017

Addresses #131

Add a new script called data databox-install-component that:

  • Takes a component name as an option (me-box/app-os-monitor)
  • Pulls the required source code
  • Builds the image
  • Adds the Databox manifest to the local app store

Toshbrown added some commits Oct 6, 2017

Remove none core components
and use ./databox-install-component to add in 

driver-sensingkit 
driver-os-monitor
app-os-monitor

To provide minimal functionality.
Fixed test
Curl on osx did not error for a malfomed url http:/127.0.0.1 !!

@Toshbrown Toshbrown requested a review from mor1 Oct 6, 2017

@mor1

Minor tweaks/corrections suggested
Progress though :)

./databox-install-component driver-os-monitor
```
This will download and build the code on your machine and upload the Databox manifest to your local app store. You can also use this with your repositories and forks using:

This comment has been minimized.

@mor1

mor1 Oct 8, 2017

Contributor

Is a local app store guaranteed to be running?

@mor1

mor1 Oct 8, 2017

Contributor

Is a local app store guaranteed to be running?

This comment has been minimized.

@Toshbrown

Toshbrown Oct 9, 2017

Contributor

For now, it is run in all modes and the container manager UI will query both the local and remote app store. If an image is present in both then a drop-down list is displayed to select the one you want.

@Toshbrown

Toshbrown Oct 9, 2017

Contributor

For now, it is run in all modes and the container manager UI will query both the local and remote app store. If an image is present in both then a drop-down list is displayed to select the one you want.

This comment has been minimized.

@mor1

mor1 Oct 9, 2017

Contributor

Ok-- so the answer is "yes" currently? Will do for now, obvs we want to move away from that at some point.

@mor1

mor1 Oct 9, 2017

Contributor

Ok-- so the answer is "yes" currently? Will do for now, obvs we want to move away from that at some point.

* [databox-store-timeseries](https://github.com/me-box/store-timeseries)
* [databox-app-server](https://github.com/me-box/platform-app-server) Server for storing and serving databox manifests

This comment has been minimized.

@mor1

mor1 Oct 8, 2017

Contributor

Worth adding short descriptions (and consistent naming format) to all of these

@mor1

mor1 Oct 8, 2017

Contributor

Worth adding short descriptions (and consistent naming format) to all of these

This comment has been minimized.

@Toshbrown

Toshbrown Oct 9, 2017

Contributor

Should this be a separate issue for documentation? Rather than part of this PR

@Toshbrown

Toshbrown Oct 9, 2017

Contributor

Should this be a separate issue for documentation? Rather than part of this PR

This comment has been minimized.

@pooyadav

pooyadav Oct 9, 2017

Contributor

I'll create a new PR for this.

@pooyadav

pooyadav Oct 9, 2017

Contributor

I'll create a new PR for this.

This comment has been minimized.

@Toshbrown

Toshbrown Oct 9, 2017

Contributor

Cheers 👍

@Toshbrown

Toshbrown Oct 9, 2017

Contributor

Cheers 👍

Show outdated Hide outdated README.md
Show outdated Hide outdated README.md
Show outdated Hide outdated databox-install-component
Show outdated Hide outdated databox-install-component
Show outdated Hide outdated databox-install-component
@Toshbrown

This comment has been minimized.

Show comment
Hide comment
@Toshbrown

Toshbrown Oct 9, 2017

Contributor

ping @mor1 RTM?

Contributor

Toshbrown commented Oct 9, 2017

ping @mor1 RTM?

* [lib-node-databox](https://github.com/me-box/node-databox): Databox nodejs api library for building databox apps and drivers.
* [lib-python-databox](https://github.com/me-box/lib-python-databox): Databox python api library for building databox apps and drivers.
* [lib-go-databox](https://github.com/me-box/lib-go-databox): Databox go api library for building databox apps and drivers.
For writing a new driver or app for Databox, one needs [Databox API's](./documents/api_specification.md). To make app/driver development easy, we have wrapped Databox API's in [nodejs](https://nodejs.org/en/), [python](https://docs.python.org/3.4/library/index.html) and [go](https://golang.org/). Using any of these libraries, a developer can build their databox app/driver.

This comment has been minimized.

@mor1

mor1 Oct 9, 2017

Contributor

(API's should be APIs -- plural needs no apostrophe...)

@mor1

mor1 Oct 9, 2017

Contributor

(API's should be APIs -- plural needs no apostrophe...)

@mor1 mor1 merged commit 5df13d4 into master Oct 9, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
@mor1

This comment has been minimized.

Show comment
Hide comment
@mor1

mor1 Oct 9, 2017

Contributor

Merged on the basis that it's an improvement even if not perfect :)
Will await follow up PRs with other tweaks/fixes/improvements.

Contributor

mor1 commented Oct 9, 2017

Merged on the basis that it's an improvement even if not perfect :)
Will await follow up PRs with other tweaks/fixes/improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment