New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic integration test #94

Merged
merged 39 commits into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@Toshbrown
Contributor

Toshbrown commented Sep 21, 2017

Addresses issue #55 for the databox main repo

This test set of test will:

  1. Build all the core components
  2. Strat databox
  3. Check the container manager UI is available
  4. Check the arbiter is available
  5. Install driver-os-monitor
  6. Install app-os-monitor
  7. Check that the app-os-monitor UI is available

Toshbrown added some commits Sep 21, 2017

Test Driver and App install
uses driver-os-monitor and app-os-monitor to check basic functionality

@Toshbrown Toshbrown requested review from mor1 and yousefamar Sep 21, 2017

@Toshbrown

This comment has been minimized.

Show comment
Hide comment
@Toshbrown

Toshbrown Sep 21, 2017

Contributor

Test fails due to missing platform-app-store fix incoming

Contributor

Toshbrown commented Sep 21, 2017

Test fails due to missing platform-app-store fix incoming

Toshbrown added some commits Sep 21, 2017

Test Driver and App install
uses driver-os-monitor and app-os-monitor to check basic functionality
Only build want we need in testing
Should speed things up abit
Make test fail!!!
And output debug info
Wait a bit longer
travis can take a while to start up databox
Wait longer jic
But i think its a docker version issue
Sleeping for longer seems to help
lets seep evan more
Looks like builds are failing
lets try prebuild images just to make sure
Remove store-timeseries
Untill the build is faster ;-)
Move from using docker compose for building
With docker compose its hard to tell if one of the many builds fail. Making it harder to track down errors. Moving to a build script gives us more control

Toshbrown added some commits Sep 21, 2017

Fix built image names
Face hits palm
@mor1

This comment has been minimized.

Show comment
Hide comment
@mor1

mor1 Sep 25, 2017

Contributor

Looks basically in the right direction.
Some typos in messages etc :)
Do you want me to try a full review on this yet, or are you still finishing the PR? (In which case I'll wait to review until it's ready I think.)

Contributor

mor1 commented Sep 25, 2017

Looks basically in the right direction.
Some typos in messages etc :)
Do you want me to try a full review on this yet, or are you still finishing the PR? (In which case I'll wait to review until it's ready I think.)

script:
- exit 0
- ./databox-test

This comment has been minimized.

@mor1

mor1 Sep 25, 2017

Contributor

put this in a scripts subdirectory or similar?

@mor1

mor1 Sep 25, 2017

Contributor

put this in a scripts subdirectory or similar?

This comment has been minimized.

@Toshbrown

Toshbrown Sep 25, 2017

Contributor

I quite like this here, might mean people get used to running it 👍

@Toshbrown

Toshbrown Sep 25, 2017

Contributor

I quite like this here, might mean people get used to running it 👍

Show outdated Hide outdated databox-build-core
Show outdated Hide outdated databox-build-core
Show outdated Hide outdated databox-start
Show outdated Hide outdated databox-test
docker ps
#can we see the CM UI
STATUS=$(curl -sL -w "%{http_code}\\n" "http://127.0.0.1:8989/" -o /dev/null)

This comment has been minimized.

@mor1

mor1 Sep 25, 2017

Contributor

odd use of -o /dev/null? i would usually just redirect to /dev/null and not use the -o flag. is there a reason?

@mor1

mor1 Sep 25, 2017

Contributor

odd use of -o /dev/null? i would usually just redirect to /dev/null and not use the -o flag. is there a reason?

This comment has been minimized.

@Toshbrown

Toshbrown Sep 25, 2017

Contributor

because 2>&1 /dev/null does not work.

@Toshbrown

Toshbrown Sep 25, 2017

Contributor

because 2>&1 /dev/null does not work.

This comment has been minimized.

@mor1

mor1 Sep 25, 2017

Contributor

Ah. -w causes display to stdout. Which helpfully causes it to intermingle with the fetched content. Ok. Less of a hack than piping through tail I guess.

@mor1

mor1 Sep 25, 2017

Contributor

Ah. -w causes display to stdout. Which helpfully causes it to intermingle with the fetched content. Ok. Less of a hack than piping through tail I guess.

@@ -3,24 +3,12 @@ version: '3'
# Build only (put your images in here)
services:

This comment has been minimized.

@mor1

mor1 Sep 25, 2017

Contributor

why are the stanzas below being removed from the dev version?

@mor1

mor1 Sep 25, 2017

Contributor

why are the stanzas below being removed from the dev version?

This comment has been minimized.

@Toshbrown

Toshbrown Sep 25, 2017

Contributor

store-json, driver-os-monitor and app-os-monitor are needed for testing so have been moved into core as they are no longer optional. Store-json will be replaced by store-timeseries when its ready.

@Toshbrown

Toshbrown Sep 25, 2017

Contributor

store-json, driver-os-monitor and app-os-monitor are needed for testing so have been moved into core as they are no longer optional. Store-json will be replaced by store-timeseries when its ready.

Show outdated Hide outdated docker-compose.yaml
Show outdated Hide outdated docker-compose.yaml

Toshbrown added some commits Sep 25, 2017

Create scripts utilities
Has 

red() - makes $1 red 
green() - makes $1 green 
datef() - prints formated date

@mor1 mor1 merged commit 9962f10 into master Sep 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Toshbrown Toshbrown deleted the fet/travis branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment