New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updated #23

Merged
merged 5 commits into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@pooyadav
Contributor

pooyadav commented Sep 29, 2017

No description provided.

`
and upload app-manifest [/lib-node-databox/samples/app-hello-world/databox-manifest.json](./lib-node-databox/samples/app-hello-world/databox-manifest.json).
Once manifest is uploaded, close the the local manifest server by closing the browser.

This comment has been minimized.

@Toshbrown

Toshbrown Sep 29, 2017

Contributor

You're missing a step you need to add the demo apps to the docker-compose-dev-local-images.yaml file. before running ./databox-start dev

@Toshbrown

Toshbrown Sep 29, 2017

Contributor

You're missing a step you need to add the demo apps to the docker-compose-dev-local-images.yaml file. before running ./databox-start dev

This comment has been minimized.

@Toshbrown

Toshbrown Sep 29, 2017

Contributor

and in samples/driver-hello-world/README.md

@Toshbrown

Toshbrown Sep 29, 2017

Contributor

and in samples/driver-hello-world/README.md

This comment has been minimized.

@pooyadav

pooyadav Sep 29, 2017

Contributor

Yes, If you look into the readme at /lib-node-databox/samples/app-hello-world/readme the line is already there. I've not changed that line, thats why this is not shown in the changes.

@pooyadav

pooyadav Sep 29, 2017

Contributor

Yes, If you look into the readme at /lib-node-databox/samples/app-hello-world/readme the line is already there. I've not changed that line, thats why this is not shown in the changes.

This comment has been minimized.

@Toshbrown

Toshbrown Oct 3, 2017

Contributor

Sorry, missed that! LGTM

@Toshbrown

Toshbrown Oct 3, 2017

Contributor

Sorry, missed that! LGTM

`
and upload app-manifest [/lib-node-databox/samples/app-hello-world/databox-manifest.json](./lib-node-databox/samples/app-hello-world/databox-manifest.json).
Once manifest is uploaded, close the the local manifest server by closing the browser.

This comment has been minimized.

@Toshbrown

Toshbrown Oct 3, 2017

Contributor

Sorry, missed that! LGTM

@Toshbrown

Toshbrown Oct 3, 2017

Contributor

Sorry, missed that! LGTM

@Toshbrown Toshbrown merged commit a6d3b22 into me-box:master Oct 3, 2017

1 check passed

security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment