Readme updated #23
Merged
Readme updated #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toshbrown
reviewed
Sep 29, 2017
| ` | ||
| and upload app-manifest [/lib-node-databox/samples/app-hello-world/databox-manifest.json](./lib-node-databox/samples/app-hello-world/databox-manifest.json). | ||
| Once manifest is uploaded, close the the local manifest server by closing the browser. | ||
|
|
There was a problem hiding this comment.
You're missing a step you need to add the demo apps to the docker-compose-dev-local-images.yaml file. before running ./databox-start dev
There was a problem hiding this comment.
and in samples/driver-hello-world/README.md
There was a problem hiding this comment.
Yes, If you look into the readme at /lib-node-databox/samples/app-hello-world/readme the line is already there. I've not changed that line, thats why this is not shown in the changes.
Toshbrown
approved these changes
Oct 3, 2017
| ` | ||
| and upload app-manifest [/lib-node-databox/samples/app-hello-world/databox-manifest.json](./lib-node-databox/samples/app-hello-world/databox-manifest.json). | ||
| Once manifest is uploaded, close the the local manifest server by closing the browser. | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.