-
Notifications
You must be signed in to change notification settings - Fork 8
Readme updated #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme updated #23
Conversation
` | ||
and upload app-manifest [/lib-node-databox/samples/app-hello-world/databox-manifest.json](./lib-node-databox/samples/app-hello-world/databox-manifest.json). | ||
Once manifest is uploaded, close the the local manifest server by closing the browser. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing a step you need to add the demo apps to the docker-compose-dev-local-images.yaml file. before running ./databox-start dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and in samples/driver-hello-world/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, If you look into the readme at /lib-node-databox/samples/app-hello-world/readme the line is already there. I've not changed that line, thats why this is not shown in the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed that! LGTM
` | ||
and upload app-manifest [/lib-node-databox/samples/app-hello-world/databox-manifest.json](./lib-node-databox/samples/app-hello-world/databox-manifest.json). | ||
Once manifest is uploaded, close the the local manifest server by closing the browser. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed that! LGTM
No description provided.