-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise an exception if an Awaitable is omitted in a type hint (Sourcery refactored) #209
Raise an exception if an Awaitable is omitted in a type hint (Sourcery refactored) #209
Conversation
definition = self.get_definition(dep_type) | ||
if definition: | ||
if definition := self.get_definition(dep_type): | ||
return definition.get_instance(self) | ||
|
||
optional_dep_type = remove_optional_type(dep_type) | ||
if optional_dep_type: | ||
if optional_dep_type := remove_optional_type(dep_type): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function resolve
refactored with the following changes:
- Use named expression to simplify assignment and conditional [×2] (
use-named-expression
)
update_container = container_updater if container_updater else _update_nothing | ||
update_container = container_updater or _update_nothing | ||
|
||
def _update_args(supplied_args, supplied_kwargs): | ||
keys_to_skip = set(supplied_kwargs.keys()) | ||
keys_to_skip.update(spec.args[0 : len(supplied_args)]) | ||
keys_to_skip.update(spec.args[:len(supplied_args)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function partial
refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity
) - Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index
)
update_container = container_updater if container_updater else _update_nothing | ||
update_container = container_updater or _update_nothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function magic_partial
refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity
)
dep_keys_to_skip.extend(spec.args[0:skip_pos_up_to]) | ||
dep_keys_to_skip.extend(spec.args[:skip_pos_up_to]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function _infer_dependencies
refactored with the following changes:
- Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index
)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.04%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #207 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
better-async-experience
branch, then run:Help us improve this pull request!