Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an exception if an Awaitable is omitted in a type hint (Sourcery refactored) #209

Closed

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Aug 24, 2022

Pull Request #207 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the better-async-experience branch, then run:

git fetch origin sourcery/better-async-experience
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from meadsteve August 24, 2022 18:51
Comment on lines -246 to +249
definition = self.get_definition(dep_type)
if definition:
if definition := self.get_definition(dep_type):
return definition.get_instance(self)

optional_dep_type = remove_optional_type(dep_type)
if optional_dep_type:
if optional_dep_type := remove_optional_type(dep_type):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function resolve refactored with the following changes:

Comment on lines -286 to +288
update_container = container_updater if container_updater else _update_nothing
update_container = container_updater or _update_nothing

def _update_args(supplied_args, supplied_kwargs):
keys_to_skip = set(supplied_kwargs.keys())
keys_to_skip.update(spec.args[0 : len(supplied_args)])
keys_to_skip.update(spec.args[:len(supplied_args)])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function partial refactored with the following changes:

Comment on lines -331 to +329
update_container = container_updater if container_updater else _update_nothing
update_container = container_updater or _update_nothing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function magic_partial refactored with the following changes:

Comment on lines -410 to +408
dep_keys_to_skip.extend(spec.args[0:skip_pos_up_to])
dep_keys_to_skip.extend(spec.args[:skip_pos_up_to])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function _infer_dependencies refactored with the following changes:

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Aug 24, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.04%.

Quality metrics Before After Change
Complexity 2.28 ⭐ 2.26 ⭐ -0.02 👍
Method Length 49.27 ⭐ 49.04 ⭐ -0.23 👍
Working memory 4.53 ⭐ 4.56 ⭐ 0.03 👎
Quality 80.87% 80.83% -0.04% 👎
Other metrics Before After Change
Lines 427 425 -2
Changed files Quality Before Quality After Quality Change
lagom/container.py 80.87% ⭐ 80.83% ⭐ -0.04% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lagom/container.py _infer_dependencies 3 ⭐ 96 🙂 11 😞 64.67% 🙂 Extract out complex expressions
lagom/container.py partial 1 ⭐ 137 😞 70.43% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@meadsteve meadsteve closed this Aug 24, 2022
@meadsteve meadsteve deleted the sourcery/better-async-experience branch August 24, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant