Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Plan to Eat migration #2635

Conversation

NullCosmos
Copy link
Contributor

What type of PR is this?

  • documentation
  • feature

What this PR does / why we need it:

  • Improvement: mealie/services/scraper/cleaner was updated to filter out any ingredients that are blank.
  • Feature: Added a migration for Plan to Eat CSV exports.
  • Feature: Added an image_scraper to migration_helpers so that image urls can be scraped from the Plan to Eat export.

Which issue(s) this PR fixes:

Not applicable.

Special notes for your reviewer:

Borrowed code layout, style, & format from Paprika migration implementation.

Testing

  • Added a unit test for Plan to Eat that includes 3 scenarios, including blank fields & extra newlines to ensure it handles missing data correctly.
  • Tested a full migration using my personal recipe export containing over 200 recipes.

image

image

image

Release Notes

Adds Plan to Eat to list of compatible migrations

Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! FYI for the future - you only need to add new translation strings to the en-US.json file, we have automations to take care of the rest.

@michael-genson michael-genson enabled auto-merge (squash) October 15, 2023 19:57
@michael-genson michael-genson merged commit f72fcc3 into mealie-recipes:mealie-next Oct 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants