Update dockerfile for development and production #1491

Merged
merged 6 commits into from Sep 9, 2016

Projects

None yet

4 participants

@FedeG
Contributor
FedeG commented Sep 8, 2016

feat(deploy) Update dockerfile for development and production.

Fix error #1453 (docker in production mode fails)
Add .dockerignore
Corrected SYNTAX some fixes #1468
Dockerfile optimized and improved
Dockerfile-production optimized and improved

Fixes #1468
Fixes #1453

FedeG added some commits Sep 7, 2016
FedeG Fix(#1468) - Corrected SYNTAX some fixes a8de7fc
FedeG Fix(#1468) - Fix(#1453) - Corrected SYNTAX some fixes for production …
…and fix this bug #1453
180d038
FedeG Fix(#1453) - Add .dockerignore e50f250
FedeG Update Dockerfile-production 5587c15
FedeG Update Dockerfile development 9d1a592
FedeG Merge branch 'master' of https://github.com/meanjs/mean into update_d…
…ocker
ff5a415
@FedeG FedeG changed the title from Update docker to Update dockerfile for development and production Sep 8, 2016
@coveralls
coveralls commented Sep 8, 2016 edited

Coverage Status

Coverage remained the same at 72.998% when pulling ff5a415 on FedeG:update_docker into 1a274d2 on meanjs:master.

@mleanos
Member
mleanos commented Sep 8, 2016

Is this a replacement for #1468?

@FedeG
Contributor
FedeG commented Sep 8, 2016

yes, and add more improvements

@lirantal lirantal merged commit e25670a into meanjs:master Sep 9, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 72.998%
Details
@lirantal lirantal self-assigned this Sep 9, 2016
@lirantal lirantal added this to the 0.5.0 milestone Sep 9, 2016
@lirantal
Member
lirantal commented Sep 9, 2016

@FedeG should it still be possible to execute a shell on the development image such as with:
docker exec -it /bin/bash meanjs ?
I'm getting an EOF error which I didn't before.

@FedeG
Contributor
FedeG commented Sep 9, 2016 edited

@lirantal The command docker exec -it /bin/bash meanjs is invalid docker command, the correct command is docker exec -it meanjs /bin/bash
Docker exec sintax: docker exec -it <container_in_runtime> <command>

@FedeG
Contributor
FedeG commented Sep 9, 2016

@lirantal When you send invalid container name to docker exec, the exec command returned EOF.
In your command, "/bin/bash" is the name of container and docker don't find this container.

@lirantal
Member
lirantal commented Sep 9, 2016

Silly me, thanks for clearing out the confusion. Was on auto-pilot.

@FedeG FedeG deleted the FedeG:update_docker branch Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment