Blog #103
Merged
Blog #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvxd
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Beautiful work ✨
The typographic changes seem to really elevate things (to my layman's eye) 😍 In future, it might also be fun to play around with an inter / serif pairing (with serif for body) .
I've left some comments, most of which are just questions.
Can't wait to get this in!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's enough in this PR to get a very simple blog live, see preview URL. Unblocks Multi-page site tasks. And related #97.
Here's bunch of addtional features we definately want, but for sake of PR sanity, I can peel these out into separate issues.
Headerscroll borderMenuLinkadd code syntax highlighting toAdd code syntax highlightingMarkdownJSON schema for blogAdd JSON schemaRSS feedAdd RSS feedsupport Github-flavoured markdown (tables, strike-through, html) inAdd GitHub Flavored Markdown supportMarkdownNot blog
consider makingSpaceresponsive and reducing size optionsreconsideralignandmaxWidthprops (prefer to handle with grid/columns component and nested dropzones)systematise shadowsSite system tweaks