fix: restore InterVariable #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been linked to Shortcut Story #2577: Investigate duplicate Inter issue. |
monospaced
force-pushed
the
bug/sc-2577
branch
from
83d0736
to
bbb739b
Compare
monospaced
force-pushed
the
bug/sc-2577
branch
from
bbb739b
to
d034218
Compare
anglepoised
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Super interesting, thanks @monospaced. Hadn't realised Next did that.
I checked in Chrome and Firefox. Had to do some cache clearing, but all looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is a bit crazy. Next.js (not Vercel, it works locally too) now automatcially downloads whatever Inter (and other?) fonts as required from scanning the CSS. So we don't need to declare a
@font-face, or host any font files. I also had a mental note to upgrade to Inter 4, but we're already on it!This behaviour is triggered by the name
Interin afont-familydeclaration, but that gives you indvidual files per weight/style. Name for variable Inter isInterVariable, so I've updated to use that (in an@supportscause that also works, so why not). I've also added the recommend fix for Chrome.Quick test with/without
InterVariableon the preview branch showed better Lighthouse perf with variable, but we should check again on merge.