New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release engineering of logging facilities #148

Merged
merged 2 commits into from Aug 29, 2015

Conversation

Projects
None yet
1 participant
@bassosimone
Member

bassosimone commented Aug 29, 2015

  • rename log.hpp logger.hpp for consistency
  • coding style
  • allow to completely quiet a logger with set_verbose(-1)
  • be robust to set_log_function(nullptr)
  • add docstrings and documentation
  • set_log_function() -> on_log() for consistency
  • model Logger::global() on Libs::global()
Release engineering of logging facilities
- rename log.hpp logger.hpp for consistency

- coding style

- allow to completely quiet a logger with set_verbose(-1)

- be robust to set_log_function(nullptr)

- add docstrings and documentation

- set_log_function() -> on_log() for consistency

- model Logger::global() on Libs::global()

@bassosimone bassosimone added the hotfix label Aug 29, 2015

@bassosimone bassosimone self-assigned this Aug 29, 2015

@bassosimone bassosimone added this to the measurement-kit 0.1.0 milestone Aug 29, 2015

Fix includes in traceroute
Eh, this does not compile on MacOS, so I missed it :).

bassosimone added a commit that referenced this pull request Aug 29, 2015

@bassosimone bassosimone merged commit 482c328 into master Aug 29, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bassosimone bassosimone deleted the feature/logger-only-simple branch Aug 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment