New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release engineering of common/net_test.hpp #149

Merged
merged 1 commit into from Aug 29, 2015

Conversation

Projects
None yet
1 participant
@bassosimone
Member

bassosimone commented Aug 29, 2015

  • use class, not struct
  • rename on_log() for consistency
  • rename set_verbose()
  • coding style
  • move destructor in .cpp file to avoid weak-vtable warning
Release engineering of common/net_test.hpp
- use class, not struct

- rename on_log() for consistency

- rename set_verbose()

- coding style

- move destructor in .cpp file to avoid weak-vtable warning

@bassosimone bassosimone added the hotfix label Aug 29, 2015

@bassosimone bassosimone self-assigned this Aug 29, 2015

@bassosimone bassosimone added this to the measurement-kit 0.1.0 milestone Aug 29, 2015

bassosimone added a commit that referenced this pull request Aug 29, 2015

Merge pull request #149 from measurement-kit/feature/common-net-test
Release engineering of common/net_test.hpp

@bassosimone bassosimone merged commit 92e22e1 into master Aug 29, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bassosimone bassosimone deleted the feature/common-net-test branch Aug 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment