New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More simple dns changes #169

Merged
merged 2 commits into from Sep 5, 2015

Conversation

Projects
None yet
1 participant
@bassosimone
Member

bassosimone commented Sep 5, 2015

  1. Use less &&value and less std::move(). Since I don't fully understand what those two C++11 features do in practice, I've decided not to use them. I will do more research after the release to understand whether we need this stuff or not.
  2. Save and export response evdns type. Useful to avoid storing context in a lambda in src/connection.cpp
Use less &&value and less std::move()
Since I don't fully understand what those two C++11 features do
in practice, I've decided not to use them.

@bassosimone bassosimone self-assigned this Sep 5, 2015

@bassosimone bassosimone added this to the measurement-kit 0.1.0 milestone Sep 5, 2015

@bassosimone bassosimone changed the title from Use less &&value and less std::move() to More simple dns changes Sep 5, 2015

bassosimone added a commit that referenced this pull request Sep 5, 2015

@bassosimone bassosimone merged commit 0fa27e0 into measurement-kit:master Sep 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bassosimone bassosimone deleted the bassosimone:cleanup/dns-usage-of-move branch Sep 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment