Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
NDT client: first iteration #441
This branch has now reached the "ready for review state". It contains the initial implementation of the NDT client, already good enough to start testing with it and already tested enough (coverage super high for all files of this pull request) to stay in master. Issue #400 highlights future improvements that could be implemented as separate pull requests once this branch has been merged.
Conflicts: include/measurement_kit/common/logger.hpp include/measurement_kit/common/net_test.hpp src/common/logger.cpp
Refactor code selecting the test to run and eventually erroring out such that it's easier to see what happens if a test id is not recognized. Specifically, calling the callback of the stage with an error should lead to the connection being closed by the client. This diff is best read enabling the `-w` option to ignore space changes.
This should make a diff that is listed in the conversation on github obsolete, thus facilitating code review.