It looks like maybe Faraday was wanted as it was in the Gemfile initially.
This allows people to put in their own adapter/logging or whatever for running a test harness or maybe recording the SMS messages sent.
wip for swapping out Net::HTTP for Faraday
moving dependencies into gemspec, also added debugger
added support for faraday
remove require for ruby-debug
removed sample URL and commented out logging
making connection swappable
added attr readers for connection and adapter
Revert "added attr readers for connection and adapter"
This reverts commit 4c801c3.
renamed gem to shutl_clockworksms
adding license finder to track open source usage
moving license_finder to development group
Are you still looking for us to add Faraday in to the Clockworksms gem? We've changed maintainer and if you could give me a brief overview of this pull request (I don't know anything about Faraday) I'm happy to look at merging it in.
Hey, thanks for getting back to me. Well I'm not working at shutl anymore, I think @kajboj or @drouchy may know if it's still used there. I can see the last couple of commits were specific to shutl so they would need to do a new PR.
Basically Faraday is a nice way you can introduce middleware into HTTP requests, and makes it easier to test too. E.g. we wrote some middleware at shutl for logging the text messages sent out.