New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #10

wants to merge 1 commit into
base: master


None yet
3 participants

johmanx10 commented Jul 9, 2018

No description provided.

@johmanx10 johmanx10 self-assigned this Jul 9, 2018

@johmanx10 johmanx10 requested review from sjokki and michielfb Jul 9, 2018


This comment has been minimized.


sjokki commented Jul 11, 2018

I think it is rather excessive to require all this information for a pull request. Note that the template was not used while creating this pull request ( #10 ).


This comment has been minimized.


johmanx10 commented Jul 11, 2018

@sjokki should we leave out the template altogether for now, or do you see merit in a simplified version. I heavily reused an existing template, but looking back at it, I'm not sure I'd want any of this required.

@johmanx10 johmanx10 closed this Jul 20, 2018

@johmanx10 johmanx10 deleted the pull-request-template branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment