New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Dailymotion integration #663

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@Fab1en
Contributor

Fab1en commented Nov 23, 2012

Hi John
Here is my first attempt to introduce Dailymotion video support. It's basically a copy-paste of the YouTube integration code, because most of the javascript API is common between YouTube and DailyMotion.

What do you think about it ?

If you think it should be rewrited to better share code between those two external providers, feel free to suggest me how to achieve this.

@yunjiali

This comment has been minimized.

Show comment
Hide comment
@yunjiali

yunjiali Jan 15, 2013

Thanks Fab1en for your work of DailyMotion integration. I have tried the demo page you developed at mediaelementplayer-dailymotion.html (as well as in my own project), but it seems to me that the player cannot be initialised. The "Download File" link is shown instead. Do you have any idea why it is not working now? Many thanks.

yunjiali commented on 18f41a3 Jan 15, 2013

Thanks Fab1en for your work of DailyMotion integration. I have tried the demo page you developed at mediaelementplayer-dailymotion.html (as well as in my own project), but it seems to me that the player cannot be initialised. The "Download File" link is shown instead. Do you have any idea why it is not working now? Many thanks.

This comment has been minimized.

Show comment
Hide comment
@Fab1en

Fab1en Jan 15, 2013

Owner

Hi Yunjia Li
I think the problem is because you did not (and I either) built the project. If you have python installed on your environment, you can simply go to the src directory and then run python Builder.py command. This will regenerate all the files in the build directory and make my example work.

I will try to find the time to push a new commit with the build directory up-to-date.

Owner

Fab1en replied Jan 15, 2013

Hi Yunjia Li
I think the problem is because you did not (and I either) built the project. If you have python installed on your environment, you can simply go to the src directory and then run python Builder.py command. This will regenerate all the files in the build directory and make my example work.

I will try to find the time to push a new commit with the build directory up-to-date.

@yunjiali

This comment has been minimized.

Show comment
Hide comment
@yunjiali

yunjiali Jan 15, 2013

Thanks very much! It works now.

yunjiali commented Jan 15, 2013

Thanks very much! It works now.

@JunkyDeLuxe

This comment has been minimized.

Show comment
Hide comment
@JunkyDeLuxe

JunkyDeLuxe Dec 9, 2013

Hi, i am very interested by the integration of dailymotion player. Where can I find the demo mediaelementplayer-dailymotion.html ?
When I clone the mediaelementjs, i haven't seen it.
Thx for your great job ;)
And when I look for "dailymotion" in the source code of the js file, I see anything. Not in production ?

JunkyDeLuxe commented Dec 9, 2013

Hi, i am very interested by the integration of dailymotion player. Where can I find the demo mediaelementplayer-dailymotion.html ?
When I clone the mediaelementjs, i haven't seen it.
Thx for your great job ;)
And when I look for "dailymotion" in the source code of the js file, I see anything. Not in production ?

@JunkyDeLuxe

This comment has been minimized.

Show comment
Hide comment
@JunkyDeLuxe

JunkyDeLuxe Dec 9, 2013

I have pasted the code from the pull request, with the dailymotion management. That's works nice.
But I don't understand why in your web site, http://mediaelementjs.com/, the source code of the archive doesn't include the dailymotion case ?

JunkyDeLuxe commented Dec 9, 2013

I have pasted the code from the pull request, with the dailymotion management. That's works nice.
But I don't understand why in your web site, http://mediaelementjs.com/, the source code of the archive doesn't include the dailymotion case ?

@Fab1en

This comment has been minimized.

Show comment
Hide comment
@Fab1en

Fab1en Dec 9, 2013

Contributor

But I don't understand why in your web site, http://mediaelementjs.com/, the source code of the archive doesn't include the dailymotion case ?

@JunkyDeLuxe This repo is not mine, I just forked it from johndyer/mediaelement. Only the pull request is mine, so it's normal that you found the code in the pull request and not on the website. I hope you will find it when John Dyer will be OK to merge my pull request.

Contributor

Fab1en commented Dec 9, 2013

But I don't understand why in your web site, http://mediaelementjs.com/, the source code of the archive doesn't include the dailymotion case ?

@JunkyDeLuxe This repo is not mine, I just forked it from johndyer/mediaelement. Only the pull request is mine, so it's normal that you found the code in the pull request and not on the website. I hope you will find it when John Dyer will be OK to merge my pull request.

@JunkyDeLuxe

This comment has been minimized.

Show comment
Hide comment
@JunkyDeLuxe

JunkyDeLuxe Dec 12, 2013

Hey, yes ok I understand. I hope he will merge that, because its awesome. But I have a small problem. I am trying to interrupt the ad loading before the launching of the dailymotion link video ? Do you think it's possible ?
It's very boring, there is 25 seconds of ad before the reading of the stream ...
I know mediaelement block youtube ad, so perhaps there is a way to do the same with DM ?

JunkyDeLuxe commented Dec 12, 2013

Hey, yes ok I understand. I hope he will merge that, because its awesome. But I have a small problem. I am trying to interrupt the ad loading before the launching of the dailymotion link video ? Do you think it's possible ?
It's very boring, there is 25 seconds of ad before the reading of the stream ...
I know mediaelement block youtube ad, so perhaps there is a way to do the same with DM ?

@PierrickMartos

This comment has been minimized.

Show comment
Hide comment
@PierrickMartos

PierrickMartos Sep 3, 2014

Hello, i'm very interested also by the dailymotion integration, thanks a lot @Fab1en. @johndyer could you merge the PR ? Is there something that i can do to help? Thanks!

PierrickMartos commented Sep 3, 2014

Hello, i'm very interested also by the dailymotion integration, thanks a lot @Fab1en. @johndyer could you merge the PR ? Is there something that i can do to help? Thanks!

@ethaizone

This comment has been minimized.

Show comment
Hide comment
@ethaizone

ethaizone Jan 17, 2016

This one cannot ,merge and not worth to merge because embed api deprecated. I tried and it's not work. Current dailymotion has two ways for us. One is iframe and another is oEmbed. Cut oEmbed out because it require server-side implement.

ethaizone commented Jan 17, 2016

This one cannot ,merge and not worth to merge because embed api deprecated. I tried and it's not work. Current dailymotion has two ways for us. One is iframe and another is oEmbed. Cut oEmbed out because it require server-side implement.

@rafa8626

This comment has been minimized.

Show comment
Hide comment
@rafa8626

rafa8626 Aug 1, 2016

Collaborator

@Fab1en Thanks for the awesome work on this PR. However, we will close this PR since the approach described is deprecated. If you want to, please submit a new PR with updated code. Thanks so much!

Collaborator

rafa8626 commented Aug 1, 2016

@Fab1en Thanks for the awesome work on this PR. However, we will close this PR since the approach described is deprecated. If you want to, please submit a new PR with updated code. Thanks so much!

@rafa8626 rafa8626 closed this Aug 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment