New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email as username breaks all methods to get parts of authority: host(), port(), username(), etc. #108

Closed
caseydawsonjordan opened this Issue Aug 13, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@caseydawsonjordan

caseydawsonjordan commented Aug 13, 2013

@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Aug 13, 2013

Member

nice catch!

Member

rodneyrehm commented Aug 13, 2013

nice catch!

@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Aug 14, 2013

Member

I've modified the parser to accept your input. you should be aware of the fact that the URI you provided is malformed - i.e. the @ needs to be percent-encoded. This is fixed in master and will be included in the next release.

Thank you!

Member

rodneyrehm commented Aug 14, 2013

I've modified the parser to accept your input. you should be aware of the fact that the URI you provided is malformed - i.e. the @ needs to be percent-encoded. This is fixed in master and will be included in the next release.

Thank you!

@rodneyrehm rodneyrehm closed this Aug 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment