New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPV6 with brackets are parsed incorrectly #144

Closed
Jellyfrog opened this Issue Apr 15, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@Jellyfrog

http://jsbin.com/qarikafe/1/edit

input: http://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80/index.html 
urijs: http://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80/index.html 
--- 
input: http://[1080:0:0:0:8:800:200C:417A]/index.html
urijs: http://[1080:0:0:0:8:800:200C:417A]://index.html 
--- 
input: http://[3ffe:2a00:100:7031::1]
urijs: http://3ffe:2a00:100:7031::1/
--- 
input: http://[1080::8:800:200C:417A]/foo 
urijs: http://[1080::8:800:200C:417A]://foo

---
input: http://[::192.9.5.5]/ipng 
urijs: http://[::192.9.5.5]://ipng

---
input: http://[::FFFF:129.144.52.38]:80/index.html 
urijs: http://[::FFFF:129.144.52.38]:80/index.html
--- 
input: http://[2010:836B:4179::836B:4179] 
urijs: http://2010:836B:4179::836B:4179/ 
--- 

@rodneyrehm rodneyrehm added the Bug label Apr 15, 2014

@Jellyfrog

This comment has been minimized.

Show comment
Hide comment
@Jellyfrog

Jellyfrog Apr 15, 2014

Wow, fast.

Wow, fast.

@Jellyfrog

This comment has been minimized.

Show comment
Hide comment
@Jellyfrog

Jellyfrog Apr 15, 2014

Found a bug tho :(

new URI('http://[::1]').toString();
// http://[::1]/ 
new URI('http://[::1]').normalize().toString();
// http://:1/ 

Found a bug tho :(

new URI('http://[::1]').toString();
// http://[::1]/ 
new URI('http://[::1]').normalize().toString();
// http://:1/ 
@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Apr 15, 2014

Member

please open a new issue. This already happened in v1.12.1 and is thus not a regression caused by this fix.

Member

rodneyrehm commented Apr 15, 2014

please open a new issue. This already happened in v1.12.1 and is thus not a regression caused by this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment