New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'audio: src' to URI.domAttributes #160

Closed
mbutsko opened this Issue Aug 19, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@mbutsko
Contributor

mbutsko commented Aug 19, 2014

Using the jQuery plugin, if this tag is present: <audio src="/path/to/some.mp3">
then I get this error:

Uncaught Error: Element "AUDIO" does not have either property: href, src, action, cite

src is a valid attribute for audio, so is it reasonable to add audio: src to Uri.domAttributes?

@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Aug 20, 2014

Member

Yes, <audio> and <video> may have a src as well. good catch!

Care to add them to the source and send a PR?

Member

rodneyrehm commented Aug 20, 2014

Yes, <audio> and <video> may have a src as well. good catch!

Care to add them to the source and send a PR?

@rodneyrehm rodneyrehm added the Bug label Aug 20, 2014

@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Aug 20, 2014

Member

PR merged, thx

Member

rodneyrehm commented Aug 20, 2014

PR merged, thx

@rodneyrehm rodneyrehm closed this Aug 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment