New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong protocol identification for relative URL with colons #49

Closed
Ragnarokkr opened this Issue Oct 20, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@Ragnarokkr

Ragnarokkr commented Oct 20, 2012

I think to have found a minor issue, in URI parsing.

You can replicate this issue using the Wikipedia links. For example, parsing a local URL on Wikipedia:

<a href="/wiki/Help:IPA">....</a>

the URI.parse() method returns for protocol

/wiki/Help

and for path

IPA

and this is clearly wrong.

@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Oct 21, 2012

Member

good catch! I'll look into it

Member

rodneyrehm commented Oct 21, 2012

good catch! I'll look into it

@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Oct 21, 2012

Member

This issue has been adressed and is fixed in v1.7.4

Member

rodneyrehm commented Oct 21, 2012

This issue has been adressed and is fixed in v1.7.4

@rodneyrehm rodneyrehm closed this Oct 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment