New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corner cases not handled correctly by normalizePath #97

Closed
wrr opened this Issue Jul 23, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@wrr

wrr commented Jul 23, 2013

I found following two corner cases that do not seem to be handled correctly by normalizePath():

>URI('/.//').normalizePath().toString()
'//'

>URI('/foo/..').normalizePath().toString()
'/foo/..'

I can try to write a fix, if you agree that these two should both produce /

@wrr

This comment has been minimized.

Show comment
Hide comment
@wrr

wrr Jul 23, 2013

And one more:

>URI('/.').normalizePath().toString()
'/.'

wrr commented Jul 23, 2013

And one more:

>URI('/.').normalizePath().toString()
'/.'
@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Jul 24, 2013

Member

true. Maybe @djcsdy has some htoughts on that, he already fixed a couple of edge cases (see open pull requests)

Member

rodneyrehm commented Jul 24, 2013

true. Maybe @djcsdy has some htoughts on that, he already fixed a couple of edge cases (see open pull requests)

@rodneyrehm

This comment has been minimized.

Show comment
Hide comment
@rodneyrehm

rodneyrehm Aug 3, 2013

Member

I've fixed this in master - it will be included in the next release. thank you for your help!

Member

rodneyrehm commented Aug 3, 2013

I've fixed this in master - it will be included in the next release. thank you for your help!

@rodneyrehm rodneyrehm closed this Aug 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment