Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Using indexOf() instead of Regexp() #122
Performance improvement seen at (along with the intermediate experiments using binary search):
Memory footprint on my 32-bit OS:
A test has been added to ensure all SLD are correctly processed by the new code.
added a commit
this pull request
Apr 15, 2014
I was wondering if you would be interested in the ability to support the full Public Suffix List? I think it's not too much work to fit in there publicsuffixlist.js.
User could optionally supply his own list, while the default (stock) list (if no external list supplied) would be a match of what SecondLevelDomain currently handles.
I would prefer using PublicSuffix as it used by browsers and maintained properly. I haven't used PS because it also contains entries like
If your list filters these out, we can talk about depending on or integrating your implementation (or a derivation thereof). If it doesn't, don't see how this could work.
btw. this should probably be a separate issue. care to open one?