Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addFragment/addHash method #356

Merged
merged 2 commits into from Oct 1, 2017
Merged

Conversation

fishead
Copy link
Contributor

@fishead fishead commented Aug 30, 2017

This PR solve issue #338

@@ -780,6 +780,21 @@
throw new TypeError('URI.addQuery() accepts an object, string as the name parameter');
}
};

URI.setQuery = function(data, name, value) {
Copy link
Member

@rodneyrehm rodneyrehm Aug 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind adding tests for this to test/test.js?

Copy link
Contributor Author

@fishead fishead Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sorry so the delay, I got really busy there days.

Copy link
Member

@rodneyrehm rodneyrehm Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries… I'm leaving for 2 week vacation in 1h, sorry for that delay :(

Copy link
Contributor Author

@fishead fishead Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests added, happy vacation!

@rodneyrehm rodneyrehm merged commit 29ab103 into medialize:master Oct 1, 2017
@rodneyrehm
Copy link
Member

@rodneyrehm rodneyrehm commented Oct 1, 2017

thank you for your time and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants