UglifyJS compressing causes Range Error #60

Merged
merged 1 commit into from Jan 8, 2013

Conversation

Projects
None yet
2 participants
Contributor

fidian commented Jan 7, 2013

UglifyJS2 with compression enabled and default options will see the line

"" + this.toString();

and minify it into this line

"" + this

and that normally should work, but the .valueOf() function then falls into
an infinite loop. Assigning the same function to both .toString() and
.valueOf() not only eliminates this problem, but it also shrinks the code an
eensy weensy bit.

@fidian fidian Letting uglify-js2 work better with this function
UglifyJS2 with compression enabled and default options will see the line
    "" + this.toString()
and minify it into this line
	"" + this
and that normally should work, but the .valueOf() function then falls into
an infinite loop.  Assigning the same function to both .toString() and
.valueOf() not only eliminates this problem, but it also shrinks the code an
eensy weensy bit.
2f72c33
Owner

rodneyrehm commented Jan 7, 2013

looks good! don't even remember why that used to be two separate functions.

Contributor

fidian commented Jan 8, 2013

What is the process for getting a pull request merged? Is there a wait time or a review checklist? Mandatory quarantine period? :-) I ask only because I'd love to update the git submodule in my project instead of pointing everyone on the team temporarily to my fork.

rodneyrehm merged commit cc78e29 into medialize:gh-pages Jan 8, 2013

Owner

rodneyrehm commented Jan 8, 2013

merged and released :)
(sorry, having a busy week…)

Contributor

fidian commented Jan 9, 2013

Fantastic! Thanks for getting that rolled out.
On Jan 8, 2013 5:37 PM, "Rodney Rehm" notifications@github.com wrote:

merged and released :)
(sorry, having a busy week…)


Reply to this email directly or view it on GitHubhttps://github.com/medialize/URI.js/pull/60#issuecomment-12023658.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment