jquery.ui: don't use undefined to build an initial URI #94

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

samuelcole commented May 31, 2013

If you call .attr('src') on an image that doesn't have a src yet, it momentarily changes the src to window.location, which could result in an extra request to window.location.

samuelcole added some commits May 31, 2013

@samuelcole samuelcole jquery.ui: don't use undefined to build an initial URI
If you call .attr('src') on an image that doesn't have a src yet, it momentarily changes the src to `window.location`, which could result in an extra request to `window.location`.
9270aa5
@samuelcole samuelcole jquery.uri: also protect against undefined when accessing the property 3d1539b
Owner

rodneyrehm commented Jun 1, 2013

nice catch!

👍

Any chance on merging this?

Owner

rodneyrehm commented Jul 14, 2013

yes, this will be merged eventually.

Great. Just checking because I updated my copy. It works for me.

Owner

rodneyrehm commented Aug 3, 2013

I've merged this into master - it will be included in the next release. thank you for your help!

rodneyrehm closed this Aug 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment