New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange nesting when discussion has nested headings #12

Closed
yuvipanda opened this Issue Dec 20, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@yuvipanda
Copy link
Contributor

yuvipanda commented Dec 20, 2015

https://en.wikipedia.org/wiki/Wikipedia:Teahouse/Questions/Archive_143#Deletionism.3F produces:

== Deletionism? ==
=== Deletionism? (Edit Break 1) ===
    User:AugurNZ | Time:01:51, 18 September 2013 (UTC)
        User:Writ_Keeper | Time:02:16, 18 September 2013 (UTC)
            User:AugurNZ | Time:02:52, 18 September 2013 (UTC)
                User:Cullen328 | Time:03:02, 18 September 2013 (UTC)
                    User:Cullen328 | Time:03:29, 18 September 2013 (UTC)
                        User:AugurNZ | Time:03:46, 18 September 2013 (UTC)
                            User:LtPowers | Time:14:38, 18 September 2013 (UTC)
                                User:Safetyprofessional | Time:19:30, 18 September 2013 (UTC)
    User:AugurNZ | Time:20:57, 18 September 2013 (UTC)
        User:Anne Delong | Time:21:03, 18 September 2013 (UTC)
            User:AugurNZ | Time:21:52, 18 September 2013 (UTC)
                User:Konveyor_Belt | Time:22:45, 18 September 2013 (UTC)
                    User:AugurNZ | Time:22:55, 18 September 2013 (UTC)
                        User:LukeSurl | Time:23:08, 18 September 2013 (UTC)
                            User:LukeSurl | Time:23:20, 18 September 2013 (UTC)
                                User:Konveyor_Belt | Time:23:27, 18 September 2013 (UTC)
    User:AugurNZ | Time:23:37, 18 September 2013 (UTC)
        User:Writ_Keeper | Time:23:52, 18 September 2013 (UTC)
            User:AugurNZ | Time:00:17, 19 September 2013 (UTC)
                User:Writ_Keeper | Time:00:53, 19 September 2013 (UTC)
                    User:AugurNZ | Time:01:30, 19 September 2013 (UTC)
                        User:Salvidrim | Time:02:04, 19 September 2013 (UTC)
                            User:AugurNZ | Time:18:34, 19 September 2013 (UTC)

where I'd expect the secondary heading to be somewhere in the middle. Not sure if this is a parsing issue or a pretty-print issue

@yuvipanda

This comment has been minimized.

@yuvipanda

This comment has been minimized.

Copy link
Contributor

yuvipanda commented Dec 20, 2015

This and earwig/mwparserfromhell#55 are the only obvious issues I still have left from all the Teahouse archives. Given how fickle these are, amazing work :D

@kjschiroo kjschiroo closed this Dec 20, 2015

@yuvipanda

This comment has been minimized.

Copy link
Contributor

yuvipanda commented Dec 20, 2015

Where was this fixed? I'm trying to find the commit...

@kjschiroo

This comment has been minimized.

Copy link
Collaborator

kjschiroo commented Dec 20, 2015

It looks like I didn't quiet give this enough attention when I was first looking at it. I had thought that it would also be fixed by pull request #11. After merging that I am now getting this output

== Deletionism? ==
=== Deletionism? (Edit Break 1) ===
    User:AugurNZ | Time:01:51, 18 September 2013 (UTC)
        User:Writ_Keeper | Time:02:16, 18 September 2013 (UTC)
            User:AugurNZ | Time:02:52, 18 September 2013 (UTC)
                User:Cullen328 | Time:03:02, 18 September 2013 (UTC)
                    User:Cullen328 | Time:03:29, 18 September 2013 (UTC)
                        User:AugurNZ | Time:03:46, 18 September 2013 (UTC)
                            User:LtPowers | Time:14:38, 18 September 2013 (UTC)
                                User:Safetyprofessional | Time:19:30, 18 September 2013 (UTC)
    User:AugurNZ | Time:20:57, 18 September 2013 (UTC)
        User:Anne Delong | Time:21:03, 18 September 2013 (UTC)
            User:AugurNZ | Time:21:52, 18 September 2013 (UTC)
                User:Konveyor_Belt | Time:22:45, 18 September 2013 (UTC)
                    User:AugurNZ | Time:22:55, 18 September 2013 (UTC)
                        User:LukeSurl | Time:23:08, 18 September 2013 (UTC)
                            User:LukeSurl | Time:23:20, 18 September 2013 (UTC)
                                User:Konveyor_Belt | Time:23:27, 18 September 2013 (UTC)
    User:AugurNZ | Time:23:37, 18 September 2013 (UTC)
        User:Writ_Keeper | Time:23:52, 18 September 2013 (UTC)
            User:AugurNZ | Time:00:17, 19 September 2013 (UTC)
                User:Writ_Keeper | Time:00:53, 19 September 2013 (UTC)
                    User:AugurNZ | Time:01:30, 19 September 2013 (UTC)
                        User:Salvidrim | Time:02:04, 19 September 2013 (UTC)
                            User:AugurNZ | Time:18:34, 19 September 2013 (UTC)
=== Deletionism? (Edit Break 1) ===
    User:AugurNZ | Time:23:37, 18 September 2013 (UTC)
        User:Writ_Keeper | Time:23:52, 18 September 2013 (UTC)
            User:AugurNZ | Time:00:17, 19 September 2013 (UTC)
                User:Writ_Keeper | Time:00:53, 19 September 2013 (UTC)
                    User:AugurNZ | Time:01:30, 19 September 2013 (UTC)
                        User:Salvidrim | Time:02:04, 19 September 2013 (UTC)
                            User:AugurNZ | Time:18:34, 19 September 2013 (UTC)

So === Deletionism? (Edit Break 1) === ends up in its super-section as well as just underneath it. I think that there is an argument in mwparserfromhell.get_sections that should let me fix it pretty easily.

Definitely my bad, I shouldn't have closed this one yet. Reopening.

This input also illustrates a problem with {{od|:::::::}}, but I will open a separate issue for that.

@kjschiroo kjschiroo reopened this Dec 20, 2015

@kjschiroo kjschiroo added the bug label Dec 20, 2015

@kjschiroo kjschiroo closed this in d474e2e Dec 21, 2015

@kjschiroo

This comment has been minimized.

Copy link
Collaborator

kjschiroo commented Dec 21, 2015

Commit message was a little confusing, real issue is fixed in 08c2e38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment