-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #29
Update dependencies #29
Conversation
|
requests-oauthlib 1.2.0 does support oauthlib 3.0.0 now. I don't see any advantage for this patch. |
which specifies it's own requests and oauthlib dependencies.
|
testing with requests-oauthlib 1.2.0. Also, I'm dropping the dependencies from requirements.txt that are now defined in requests-oauthlib. |
|
verified that the change works without issue, including our url rewriting we're layering on top to send users to localized login pages. |
|
Thank you! But we should probably still include |
|
makes sense! I added it back in. |
|
From https://www.sourceclear.com/vulnerability-database/security/information-disclosure/python/sid-2048, it looks like we need a version of requests that is >= 2.3.0. It looks like 2.21.0 is out. Should we require that? |
|
Yes, that was an accident to slip back to 2.2.1. 2.21.0 was what I was originally proposing. Sorry! |
|
I just pushed mwoauth 0.3.3 to pypi with this change. Thanks for your work :) |
|
Why do you test for equality instead of >= for dependencies? |
|
|
^ +1. |
There have been numerous security updates and bugfixes to the dependencies listed in requirements.txt. Updating these does not seem to have any negative impact on the Wikipedia Library Card Platform, which is currently on python2.