Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #29

Merged

Conversation

jsnshrmn
Copy link
Contributor

There have been numerous security updates and bugfixes to the dependencies listed in requirements.txt. Updating these does not seem to have any negative impact on the Wikipedia Library Card Platform, which is currently on python2.

@xqt
Copy link

xqt commented Jan 15, 2019

requests-oauthlib 1.2.0 does support oauthlib 3.0.0 now. I don't see any advantage for this patch.

which specifies it's own requests and oauthlib dependencies.
@jsnshrmn
Copy link
Contributor Author

testing with requests-oauthlib 1.2.0. Also, I'm dropping the dependencies from requirements.txt that are now defined in requests-oauthlib.

@jsnshrmn
Copy link
Contributor Author

verified that the change works without issue, including our url rewriting we're layering on top to send users to localized login pages.

@halfak
Copy link
Member

halfak commented Jan 15, 2019

Thank you! But we should probably still include requests in requirements.txt since we use it directly. See https://github.com/mediawiki-utilities/python-mwoauth/blob/master/mwoauth/functions.py#L39 and https://github.com/mediawiki-utilities/python-mwoauth/blob/master/mwoauth/functions.py#L181

@jsnshrmn
Copy link
Contributor Author

makes sense! I added it back in.

@halfak
Copy link
Member

halfak commented Jan 15, 2019

From https://www.sourceclear.com/vulnerability-database/security/information-disclosure/python/sid-2048, it looks like we need a version of requests that is >= 2.3.0. It looks like 2.21.0 is out. Should we require that?

@jsnshrmn
Copy link
Contributor Author

Yes, that was an accident to slip back to 2.2.1. 2.21.0 was what I was originally proposing. Sorry!

@halfak halfak merged commit 18b3392 into mediawiki-utilities:master Jan 15, 2019
@halfak
Copy link
Member

halfak commented Jan 15, 2019

I just pushed mwoauth 0.3.3 to pypi with this change. Thanks for your work :)

@xqt
Copy link

xqt commented Jan 15, 2019

Why do you test for equality instead of >= for dependencies?

@jsnshrmn
Copy link
Contributor Author

@xqt

  1. the dependencies were already defined using ==
  2. New deployments and old deployments of the same release have the same behavior, because they are running the same code.
  3. There are tools (such as Dependabot + CI) for assisting in the management of dependency updates on the maintainer side, instead of leaving it up to downstream users to be the first to encounter unexpected breakage from a minor update.

@halfak
Copy link
Member

halfak commented Jan 16, 2019

^ +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants