Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels for select fields are grey instead of black like other fields #6374

Closed
michaelkohn opened this issue Apr 8, 2020 · 5 comments
Closed

Labels for select fields are grey instead of black like other fields #6374

michaelkohn opened this issue Apr 8, 2020 · 5 comments
Assignees
@garethbowen
Labels
Priority: 2 - Medium Normal priority Type: Bug Fix something that isn't working as intended
Projects
3.9.0

Comments

@michaelkohn
Copy link
Member

michaelkohn commented Apr 8, 2020 •
edited

Seen in 3.8 on the cht-covid.dev instance.

For some of the select_ fields, the question (label) text is grey. For other fields, the question (label) is black. I think this is a bug but want to confirm. If it is a bug, please raise in medic/cht-core

Screen Shot 2020-04-08 at 12 24 35 AM
@abbyad
Copy link
Contributor

abbyad commented Apr 22, 2020

Yes, this is a bug and should be opened in cht-core. I thought we had it open there already, but I can't find it.

@michaelkohn michaelkohn transferred this issue from medic/config-covid Apr 26, 2020
@michaelkohn michaelkohn added the Type: Bug Fix something that isn't working as intended label Apr 26, 2020
@michaelkohn
Copy link
Member Author

Transferred to cht-core

@garethbowen
Copy link
Member

Agreed this is a bug - we should be consistent. I think they should all be the darker colour (almost black), eg:

Screenshot from 2020-04-28 13-09-26

@n-orlowski What do you think?

@garethbowen garethbowen self-assigned this Apr 28, 2020
garethbowen added a commit that referenced this issue Apr 28, 2020
@garethbowen
Make label colors consistently dark grey
ee13c07 
#6374
@n-orlowski
Copy link

Yes please!

@garethbowen garethbowen mentioned this issue Apr 28, 2020
Merged
@garethbowen garethbowen added the Priority: 2 - Medium Normal priority label Apr 28, 2020
@garethbowen garethbowen added this to To do in 3.9.0 via automation Apr 28, 2020
@garethbowen garethbowen moved this from To do to In progress in 3.9.0 Apr 28, 2020
@SCdF
Copy link
Contributor

SCdF commented Apr 29, 2020

Code reviewed and AT'd. In the process we found a second issue around text colouring of the LHS add report menu, both of which have been fixed (I checked the RHS action menu, it is also fine):

Screenshot

image

@SCdF SCdF moved this from In progress to In AT in 3.9.0 Apr 29, 2020
@SCdF SCdF closed this as completed Apr 29, 2020
3.9.0 automation moved this from In AT to Done Apr 29, 2020
@garethbowen garethbowen changed the title Labels for select_ fields are grey, black for other fields Labels for select fields are grey, black for other fields May 27, 2020
@garethbowen garethbowen changed the title Labels for select fields are grey, black for other fields Labels for select fields are grey instead of black like other fields May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethbowen garethbowen

Labels
Priority: 2 - Medium Normal priority Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.9.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@SCdF @abbyad @garethbowen @michaelkohn @n-orlowski