Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

92-person-place-creation #7275

Merged
merged 1 commit into from
Aug 30, 2021
Merged

92-person-place-creation #7275

merged 1 commit into from
Aug 30, 2021

Conversation

meghna-khemka
Copy link
Contributor

Person & Place Creation (admin only)

medic/cht-core#[92]

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@meghna-khemka meghna-khemka marked this pull request as ready for review August 30, 2021 03:29
@meghna-khemka meghna-khemka mentioned this pull request Aug 30, 2021
Open
ngaruko
ngaruko approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@ngaruko ngaruko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job!

@meghna-khemka meghna-khemka merged commit 64cf936 into master Aug 30, 2021
@meghna-khemka meghna-khemka mentioned this pull request Aug 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaruko ngaruko ngaruko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meghna-khemka @ngaruko