Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target API level requirements from August 2019 #86

Closed
kennsippell opened this issue Jun 26, 2019 · 4 comments
Closed

Target API level requirements from August 2019 #86

kennsippell opened this issue Jun 26, 2019 · 4 comments
Assignees
@kennsippell
Labels
Priority: 1 - High Blocking the next release Type: Technical issue Improve something that users won't notice
Projects
3.7.0

Comments

@kennsippell
Copy link
Member

kennsippell commented Jun 26, 2019 •
edited by garethbowen

This error appears in the Google Play Console when publishing updates to medic-android.

Target API level requirements from August 2019
Warning:

Your app currently targets API level 26 and must target at least API level 28 to ensure it is built on the latest APIs optimized for security and performance.

From August 2019, new apps must target at least Android 9.0 (API level 28).
From November 2019, app updates must target Android 9.0 (API level 28).

Tip:

Change your app's target API level. Learn how
@kennsippell kennsippell added the Priority: 1 - High Blocking the next release label Jun 26, 2019
@garethbowen garethbowen added this to To do in 3.7.0 via automation Jun 26, 2019
@garethbowen garethbowen added the Type: Technical issue Improve something that users won't notice label Jun 26, 2019
@kennsippell kennsippell self-assigned this Jul 22, 2019
@kennsippell kennsippell moved this from To do to In progress in 3.7.0 Jul 22, 2019
@kennsippell kennsippell mentioned this issue Jul 22, 2019
Merged
@kennsippell kennsippell moved this from In progress to In AT in 3.7.0 Jul 23, 2019
@kennsippell
Copy link
Member Author

Ready for AT on bump-28

@newtewt
Copy link
Contributor

newtewt commented Jul 24, 2019 •
edited

@kennsippell I have built and run the unbranded version locally and ran it against gamma.dev. I've tested on one 64bit (Pixel 2) and 2 32bit devices(Tecno J5, WX3) and the app is functioning as expected. I think it would be good to merge this and then evaluate the apks generated after to ensure they work as expected.

I think a tag at this point would be required to build all apks right?

newtewt pushed a commit that referenced this issue Jul 24, 2019
@kennsippell @newtewt
Bump target SDK version to 28 (#87)
2608929 
* Bump target SDK version to 28
* Failed to install the following Android SDK packages as some licences have not been accepted
* Bump testImplementation version of roboelectric

#86
@kennsippell
Copy link
Member Author

I see you tagged and released this as https://github.com/medic/medic-android/releases/tag/v0.4.32

@newtewt
Copy link
Contributor

newtewt commented Aug 14, 2019

Closing this out as it was already tested and a tag was created for this version.

@newtewt newtewt closed this as completed Aug 14, 2019
3.7.0 automation moved this from In AT to Done Aug 14, 2019
derickl pushed a commit that referenced this issue Jan 21, 2021
@kennsippell @newtewt
Bump target SDK version to 28 (#87)
56ba20d 
* Bump target SDK version to 28
* Failed to install the following Android SDK packages as some licences have not been accepted
* Bump testImplementation version of roboelectric

#86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennsippell kennsippell

Labels
Priority: 1 - High Blocking the next release Type: Technical issue Improve something that users won't notice
Projects
No open projects
3.7.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@garethbowen @kennsippell @newtewt