Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

medic-api forms controller should use appropriate protocol #3427

Closed
alxndrsn opened this issue Apr 28, 2017 · 2 comments
Closed

medic-api forms controller should use appropriate protocol #3427

alxndrsn opened this issue Apr 28, 2017 · 2 comments
Assignees
@ngaruko
Labels
Priority: 2 - Medium Normal priority Type: Bug Fix something that isn't working as intended
Projects
3.3.0

Comments

@alxndrsn
Copy link
Contributor

From @mandric

In medic-api:

controllers/forms.js:80 should use http or https depending on the request. We should probably check the X-Forwarded-Proto header which can be expected from the ssl proxy/nginx config?

template = 'http://%s/api/v1/forms/{{id}}.xml'.replace('%s', headers.host);
@mandric mandric added the Type: Bug Fix something that isn't working as intended label Apr 28, 2017
@sglangevin sglangevin added this to Needs Triage in Bug Manager May 5, 2017
@garethbowen garethbowen added the Quick win Expected to be an easy fix label Jun 11, 2018
@sglangevin sglangevin removed this from Backlog in Bug Manager Jul 6, 2018
@garethbowen garethbowen added the Help wanted Good for first time contributions label Aug 13, 2018
@garethbowen garethbowen self-assigned this Aug 27, 2018
garethbowen added a commit that referenced this issue Aug 27, 2018
@garethbowen
Refactors forms controller
ae9395c 
#3427 #3707
garethbowen added a commit that referenced this issue Aug 27, 2018
@garethbowen
Refactors forms controller
8798fd5 
Uses promises not callbacks
Uses new router pattern
Uses pouchdb not nano

Adds a redirect for URL with a trailing slash.
Uses http/https protocol based on the incoming request protocol.

#3707
#3427
@garethbowen garethbowen added this to To do in 3.3.0 via automation Aug 27, 2018
@garethbowen garethbowen added Status: 4 - Acceptance testing Priority: 2 - Medium Normal priority and removed Help wanted Good for first time contributions Quick win Expected to be an easy fix labels Aug 27, 2018
@garethbowen
Copy link
Member

AT: Check that the medic-collect APIs work in development (using http) and production (using https). Connect a medic-collect android app to ensure the APIs still work as expected.

@garethbowen garethbowen moved this from To do to Acceptance testing in 3.3.0 Aug 27, 2018
@garethbowen garethbowen removed their assignment Aug 27, 2018
@ngaruko ngaruko self-assigned this Dec 2, 2018
@ngaruko
Copy link
Contributor

ngaruko commented Dec 2, 2018

LGTM.

@ngaruko ngaruko closed this as completed Dec 2, 2018
3.3.0 automation moved this from In AT to Done Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngaruko ngaruko

Labels
Priority: 2 - Medium Normal priority Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.3.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mandric @alxndrsn @garethbowen @ngaruko