Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update apps to use local shared-libs #5694

Closed
dianabarsan opened this issue May 27, 2019 · 1 comment
Closed

Update apps to use local shared-libs #5694

dianabarsan opened this issue May 27, 2019 · 1 comment
Assignees
@dianabarsan
Labels
Priority: 2 - Medium Normal priority Type: Technical issue Improve something that users won't notice
Projects
3.6.0

Comments

@dianabarsan
Copy link
Member

We use npm pack to zip api and sentinel and attach them to our build ddoc as part of build process. We also use a collection of scoped (@medic/<library>) shared libraries across our apps.
Due to a bug in npm, we were forced to npm publish these libraries in order for them to be packed as bundledDependencies .

Due to the large overhead required to manage and update these published shared libraries and the fact that the bug in npm was fixed, our shared libraries can be local once more.
@dianabarsan dianabarsan added Type: Technical issue Improve something that users won't notice Priority: 2 - Medium Normal priority labels May 27, 2019
@dianabarsan dianabarsan self-assigned this May 27, 2019
@dianabarsan dianabarsan added this to To do in 3.6.0 via automation May 27, 2019
@dianabarsan dianabarsan moved this from To do to In progress in 3.6.0 May 27, 2019
@garethbowen
Copy link
Member

Ready for AT in fix-error-logging. Most of the changes only affect development, but there are some changes to how we bundle shared-libs for release. AT this in a full stack not in a development setup. Install using Horti. Then make sure the shared-libs (transitions, messages, lineage, etc) are bundled correctly into api and sentinel.

@garethbowen garethbowen moved this from In progress to In AT in 3.6.0 May 27, 2019
@dianabarsan dianabarsan mentioned this issue May 27, 2019
Merged
@garethbowen garethbowen self-assigned this Jun 19, 2019
garethbowen pushed a commit that referenced this issue Jun 19, 2019
@dianabarsan @garethbowen
Switches to use local shared-libs
704e9df 
Changes packages for all apps so shared-libs are local again.
Changes transitions error reporting to not stringify errors.
Changes lineage lib to not require pouchdb and run integration tests with memory adapter, to avoid building leveldown every time we install or test the library.
Adds jasmine reporter to improve e2e tests outputs.

#5694
3.6.0 automation moved this from In AT to Done Jun 19, 2019
@garethbowen garethbowen removed their assignment Jun 19, 2019
This was referenced Jun 20, 2019
Merged
Closed
garethbowen pushed a commit that referenced this issue Jun 23, 2019
@dianabarsan @garethbowen
Runs npm dedupe before packaging api and sentinel
6f582c8 
Post #5694 our api and sentinel bundled doubled in size because of lots of duplicated dependencies (`npm pack` straight up copies the symlinked folders ).
Running `npm dedupe` reduces our bundle sizes to what they were before.

#5739
kennsippell pushed a commit that referenced this issue Jul 5, 2019
@dianabarsan @kennsippell
Switches to use local shared-libs
ab811d8 
Changes packages for all apps so shared-libs are local again.
Changes transitions error reporting to not stringify errors.
Changes lineage lib to not require pouchdb and run integration tests with memory adapter, to avoid building leveldown every time we install or test the library.
Adds jasmine reporter to improve e2e tests outputs.

#5694
kennsippell pushed a commit that referenced this issue Jul 5, 2019
@dianabarsan @kennsippell
Runs npm dedupe before packaging api and sentinel
2530ebd 
Post #5694 our api and sentinel bundled doubled in size because of lots of duplicated dependencies (`npm pack` straight up copies the symlinked folders ).
Running `npm dedupe` reduces our bundle sizes to what they were before.

#5739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianabarsan dianabarsan

Labels
Priority: 2 - Medium Normal priority Type: Technical issue Improve something that users won't notice
Projects
No open projects
3.6.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garethbowen @dianabarsan