From 3bcf7f840ef065ae3243c7fee80807b739cc67c6 Mon Sep 17 00:00:00 2001 From: Matt Everett Date: Wed, 31 May 2023 18:58:54 -0700 Subject: [PATCH 1/3] error out if neither TrackResponse or Error are returned --- carriers/usps.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/carriers/usps.js b/carriers/usps.js index ea9c204..6407f9e 100644 --- a/carriers/usps.js +++ b/carriers/usps.js @@ -90,7 +90,7 @@ function USPS(options) { if (err) { return callback(err); - } else if (!data) { + } else if (!data || (!data.Error && !data.TrackResponse)) { return callback(new Error('Invalid or missing TrackResponse')); } else if (data.Error) { // Invalid credentials or Invalid Tracking Number From 00c258d47c6e10cb322f7512b669e520feb0181c Mon Sep 17 00:00:00 2001 From: Matt Everett Date: Wed, 31 May 2023 19:07:38 -0700 Subject: [PATCH 2/3] move the invalid resopnse check to the end --- carriers/usps.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/carriers/usps.js b/carriers/usps.js index 6407f9e..afa498e 100644 --- a/carriers/usps.js +++ b/carriers/usps.js @@ -90,12 +90,12 @@ function USPS(options) { if (err) { return callback(err); - } else if (!data || (!data.Error && !data.TrackResponse)) { + } else if (!data) { return callback(new Error('Invalid or missing TrackResponse')); } else if (data.Error) { // Invalid credentials or Invalid Tracking Number return callback(new Error(data.Error.Description[0])); - } else if (data.TrackResponse.TrackInfo[0].Error) { + } else if (!data?.TrackResponse?.TrackInfo?.[0] || data.TrackResponse.TrackInfo[0].Error) { // No Tracking Information return callback(null, results); } From ecabd95b0d84db7b5c855b251471b19f2d2fd0a7 Mon Sep 17 00:00:00 2001 From: Matt Everett Date: Thu, 1 Jun 2023 11:28:01 -0700 Subject: [PATCH 3/3] version 1.11.9 (usps resiliency updates) --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 99af1b8..b001d9a 100644 --- a/package.json +++ b/package.json @@ -40,5 +40,5 @@ "type": "git", "url": "https://github.com/mediocre/bloodhound.git" }, - "version": "1.11.8" + "version": "1.11.9" }