Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of supporting dep and modules #128

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@cep21
Copy link

commented Jun 20, 2019

An example of what it would look like to support dep and modules at the same time.

cep21 added some commits Jun 20, 2019

@cep21

This comment has been minimized.

Copy link
Author

commented Jun 20, 2019

This is mentioned as an alternative under https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher "Major subdirectory" approach. This is understandable by older versions of go, including dep. Go modules are also aware of this approach and will look in the /v3 directory for the right files.

On #53 you had a concern

only way that would work is if I copied resp and its sub-package into the main one

This keeps resp in it's own package.

Even if you don't merge this to master, making it a branch of github.com/mediocregopher/radix would allow people to reference that branch for at least some version of this repository.

It's understandably more ugly to have that /v3/ folder there, but it seems like the right approach while the Go community is in this transition period between dep and modules.

cep21 added some commits Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.