Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Share button as a BTN_, instead of KEY_RECORD #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Report Share button as a BTN_, instead of KEY_RECORD #20

wants to merge 1 commit into from

Commits on Mar 15, 2023

  1. Report Share button as a BTN_, instead of KEY_RECORD 

    KEY_RECORD is a multi-media keyboard key that starts audio recording.
This is not the meaning of the Share button.
Having the Share button report KEY_RECORD has side-effects:
- software gets confused (see e.g. libsdl-org/SDL#6296)
- The Xorg server opens the controller device, keeps it permanently open and
  reads its buttons and reports share button presses as XF86AudioRecord to
  applications. Users do not expect this.
I grepped the Linux kernel's drivers/input/joystick and there exists
NO OTHER joystick type controller that reports a KEY_ type event.
They all use BTN_* events.
I'm sure the person who added the Share button originally just grabbed
some event without giving it much thought.
    @mbenkmann
    mbenkmann committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d342f39 View commit details
    Browse the repository at this point in the history