New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify css error #15

Closed
empk opened this Issue Apr 27, 2013 · 9 comments

Comments

Projects
None yet
4 participants
@empk
Contributor

empk commented Apr 27, 2013

When trying to minify css using ?minify=true, I get the following error:

Fatal error: Call to protected Munee\Asset\Filter\Css\Minify::minify() from context 'Munee\Asset\Type' in vendor\meenie\munee\src\Munee\Asset\Type.php on line 88

@ghost ghost assigned meenie Apr 27, 2013

@meenie

This comment has been minimized.

Show comment
Hide comment
@meenie

meenie Apr 27, 2013

Owner

Hmmm.... This is quite weird. I'm not able to replicate it myself. Could you please make sure you have the latest version of Munee (1.5.11) and try it again?

Owner

meenie commented Apr 27, 2013

Hmmm.... This is quite weird. I'm not able to replicate it myself. Could you please make sure you have the latest version of Munee (1.5.11) and try it again?

@meenie

This comment has been minimized.

Show comment
Hide comment
@meenie

meenie Apr 27, 2013

Owner

It's now 1.5.12 due to your pull request.

Owner

meenie commented Apr 27, 2013

It's now 1.5.12 due to your pull request.

@empk

This comment has been minimized.

Show comment
Hide comment
@empk

empk Apr 27, 2013

Contributor

Oops, I forgot to mention something important, the PHP version.

Upon further testing, it only happens on PHP 5.3.1.

Works fine with 5.3.20 and 5.4.3. Maybe the description should be updated to say "PHP > 5.3.1 Asset Optimisation" :)

I think this is a non-issue - I'll close it. Thank you!

Contributor

empk commented Apr 27, 2013

Oops, I forgot to mention something important, the PHP version.

Upon further testing, it only happens on PHP 5.3.1.

Works fine with 5.3.20 and 5.4.3. Maybe the description should be updated to say "PHP > 5.3.1 Asset Optimisation" :)

I think this is a non-issue - I'll close it. Thank you!

@empk empk closed this Apr 27, 2013

@meenie

This comment has been minimized.

Show comment
Hide comment
@meenie

meenie Apr 27, 2013

Owner

Oh? Seems like it would have been a bug in PHP 5.3.1 because it's definitely not trying to run the protected Minify method in the context of the AssetType. It's running in the context of the actual Minify Filter. But I will update the description anyway 👍.

Owner

meenie commented Apr 27, 2013

Oh? Seems like it would have been a bug in PHP 5.3.1 because it's definitely not trying to run the protected Minify method in the context of the AssetType. It's running in the context of the actual Minify Filter. But I will update the description anyway 👍.

@zeleznypa

This comment has been minimized.

Show comment
Hide comment
@zeleznypa

zeleznypa Dec 13, 2013

I currently use this in Modx revolution on Ubuntu server with php 5.3.2 and have this error ;(

zeleznypa commented Dec 13, 2013

I currently use this in Modx revolution on Ubuntu server with php 5.3.2 and have this error ;(

@meenie

This comment has been minimized.

Show comment
Hide comment
@meenie

meenie Dec 13, 2013

Owner

I currently use this in Modx revolution on Ubuntu server with php 5.3.2 and have this error ;(

Is there any way you can update your PHP version? PHP 5.3.2 was released back in March of 2010, so it's quite old.
This is not something I'm able to fix as it's an error in PHP itself. There's no reason why a parent class can't access a childs Protected method. If it was a Private method, then yes, This is an issue.

Owner

meenie commented Dec 13, 2013

I currently use this in Modx revolution on Ubuntu server with php 5.3.2 and have this error ;(

Is there any way you can update your PHP version? PHP 5.3.2 was released back in March of 2010, so it's quite old.
This is not something I'm able to fix as it's an error in PHP itself. There's no reason why a parent class can't access a childs Protected method. If it was a Private method, then yes, This is an issue.

@zeleznypa

This comment has been minimized.

Show comment
Hide comment
@zeleznypa

zeleznypa Dec 14, 2013

No I can't because PHP 5.3.2 is the latest stable version available in Ubuntu server LTS ;(

zeleznypa commented Dec 14, 2013

No I can't because PHP 5.3.2 is the latest stable version available in Ubuntu server LTS ;(

@bezumkin

This comment has been minimized.

Show comment
Hide comment
@bezumkin

bezumkin Dec 14, 2013

Contributor

You can easily upgrade it from ppa https://launchpad.net/~ondrej/+archive/php5-oldstable

sudo add-apt-repository ppa:ondrej/php5-oldstable
sudo apt-get update && sudo apt-get upgrade
Contributor

bezumkin commented Dec 14, 2013

You can easily upgrade it from ppa https://launchpad.net/~ondrej/+archive/php5-oldstable

sudo add-apt-repository ppa:ondrej/php5-oldstable
sudo apt-get update && sudo apt-get upgrade
@zeleznypa

This comment has been minimized.

Show comment
Hide comment
@zeleznypa

zeleznypa commented Dec 15, 2013

Thanks

vita10gy added a commit to vita10gy/munee that referenced this issue Mar 12, 2015

Rename minify helper to minifyHelper
Because the class is named minify PHP is attempting to construct the
Minify object via the same named minify helper function

#15 #62

meenie added a commit that referenced this issue Mar 12, 2015

Merge pull request #63 from vita10gy/protected-minify-fix
Rename minify helper to minifyHelper

Closes #15, #62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment