From e703a52bc4741ab647d7ea0b17b3c6c74725afc0 Mon Sep 17 00:00:00 2001 From: Aaron Meese Date: Sat, 2 Mar 2024 10:26:29 -0500 Subject: [PATCH] fix: better error handling + typo correction --- backend/server/src/vfs.js | 2 +- website/package.json | 1 + website/src/server/auth/adapter.js | 16 ++++++++++------ website/src/server/auth/template.env.json | 2 ++ 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/backend/server/src/vfs.js b/backend/server/src/vfs.js index 2d4a2eca..9c2c3ca9 100644 --- a/backend/server/src/vfs.js +++ b/backend/server/src/vfs.js @@ -222,7 +222,7 @@ const createRequestFactory = (findMountpoint) => const [target, ...rest] = getter(req, res); const [resource] = rest; - if (resouce instanceof Stream) { + if (resource instanceof Stream) { resource.once("error", reject); } diff --git a/website/package.json b/website/package.json index 4b6f1026..364c88d1 100644 --- a/website/package.json +++ b/website/package.json @@ -10,6 +10,7 @@ "serve": "node src/server/index.js", "build": "webpack && npm run build:manifest", "build:production": "NODE_ENV=production rush build", + "build:prod": "npm run build:production", "build:manifest": "meese-cli package:discover", "package:discover": "meese-cli package:discover", "package:create": "meese-cli package:create", diff --git a/website/src/server/auth/adapter.js b/website/src/server/auth/adapter.js index c495b359..70d28fe3 100644 --- a/website/src/server/auth/adapter.js +++ b/website/src/server/auth/adapter.js @@ -33,13 +33,17 @@ module.exports = (_core, _options) => ({ groups = ["guest"]; } else { // Validate the user against the 'database' - const users = JSON.parse(process.env.meeseOS_users); - const usernameExists = Object.prototype.hasOwnProperty.call(users, username); - if (usernameExists) { - const passwordCorrect = users[username].password === password; - if (passwordCorrect) { - groups = users[username].groups; + try { + const users = JSON.parse(process.env.meeseOS_users); + const usernameExists = Object.prototype.hasOwnProperty.call(users, username); + if (usernameExists) { + const passwordCorrect = users[username].password === password; + if (passwordCorrect) { + groups = users[username].groups; + } } + } catch (e) { + console.error("Error validating user against the database:", e); } } diff --git a/website/src/server/auth/template.env.json b/website/src/server/auth/template.env.json index c3655639..c9ec4845 100644 --- a/website/src/server/auth/template.env.json +++ b/website/src/server/auth/template.env.json @@ -9,6 +9,8 @@ "groups": ["user"] } }, + // Randomly generate these: + // node -e "console.log(require('crypto').randomBytes(32).toString('hex'))" "SESSION_SECRET": "thiswouldbenefitfrombeingrandomlygenerated", "JWT_SECRET": "youshouldprobablyrandomlygeneratethis", "JWT_REFRESH": "youshoulddefinitelyrandomlygeneratethisaswell",