Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Wrong extension id for encrypted headers #1575
In some cases, Janus is sending an answer with a wrong extension id if encrypted extension headers are used. You can test this by enabling the flag "Negotiation with encrypted header extensions for SRTP in WebRTC" in
Offer from Chrome:
Answer from Janus:
Note that the extensions got mapped to the id of the encrypted version from the offer (that has the
The problem is caused by the code that checks if the extension name is part of the m-line attribute in
In this case this matches both the unencrypted and the encrypted extension and the last matching id (here the encrypted) is used.
When setting the answer, Chrome fails with "Failed to set remote answer sdp: Failed to set remote video description send parameters.".
referenced this issue
Apr 11, 2019
It's fine to not support encrypted extensions, that's why Chrome is offering the same extensions both encrypted and unencrypted. However it's not allowed to answer with the unencrypted extension but with the id of the encrypted extension:
The solution for now would be to ignore all encrypted extensions (that contain
Thinking more about this, re-assigning ids should be fine (i.e. using