Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add endian define/include to pp-rtp.h #1398

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@Piasy
Copy link
Contributor

Piasy commented Oct 8, 2018

without that definition, janus-pp-rec will use big endian in macOS, which will fail to convert h264 video into mp4.

add endian define/include to pp-rtp.h
without that definition, janus-pp-rec will use big endian in macOS, which will fail to convert h264 video into mp4.
@lminiero

This comment has been minimized.

Copy link
Member

lminiero commented Oct 8, 2018

Good catch, not sure why it wasn't there since it is in the core rtp.h. Merging, thanks!

@lminiero lminiero merged commit e770d68 into meetecho:master Oct 8, 2018

@Piasy Piasy deleted the Piasy:fix_pp_rec branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.