Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore encrypted extensions when processing SDP (fixes #1575). #1581

Closed

Conversation

Projects
None yet
2 participants
@fancycode
Copy link
Contributor

fancycode commented Apr 12, 2019

No description provided.

@lminiero

This comment has been minimized.

Copy link
Member

lminiero commented Apr 12, 2019

Thanks! But I think this needs to be extended to a few more plugins than just the VideoRoom. The AudioBridge also accesses extensions to check the one used for audio levels, for instance.

That said, it might be easier to just drop the encrypted extensions attributes from the SDP when doing the anonymize process: this way, plugins never get to see them at all, and nothing breaks. I'll have to check if the same issue can happen in the core too, though, as we do traverse extensions looking for mid and rid for instance.

@lminiero

This comment has been minimized.

Copy link
Member

lminiero commented Apr 15, 2019

Implemented as I said, by basically removing the encrypted extensions before passing the SDP to plugins, and viceversa. Verified that it seems to be working when I tested. I borrowed your definition in rtp.h since it was indeed useful, and we'll need it if/when we'll add proper support for encrypted extensions. Closing your PR, but thanks again for your precious help!

@lminiero lminiero closed this Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.