fix(Notifications): Fix issue that blocked notifications from e.g. Slack

adlk · adlk · commit 44c413bca461 · 2019-07-30T12:08:46.000+02:00
diff --git a/src/stores/AppStore.js b/src/stores/AppStore.js
@@ -189,7 +189,7 @@ export default class AppStore extends Store {
     if (this.stores.settings.all.app.isAppMuted) return;
 
     // TODO: is there a simple way to use blobs for notifications without storing them on disk?
-    if (options.icon.startsWith('blob:')) {
+    if (options.icon && options.icon.startsWith('blob:')) {
       delete options.icon;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ export default class AppStore extends Store {`
`189`	`189`	`if (this.stores.settings.all.app.isAppMuted) return;`
`190`	`190`
`191`	`191`	`// TODO: is there a simple way to use blobs for notifications without storing them on disk?`
`192`		`- if (options.icon.startsWith('blob:')) {`
	`192`	`+ if (options.icon && options.icon.startsWith('blob:')) {`
`193`	`193`	`delete options.icon;`
`194`	`194`	`}`
`195`	`195`