fix(Todos): Add check if recipes have been loaded before downloading todos-recipe

Author: adlk

src/features/todos/index.js

@@ -23,11 +23,20 @@ export default function initTodos(stores, actions) {
   stores.todos = todosStore;
   const { features } = stores;
 
-  // Franz todos is now deeply baked into Franz, therefore the recipe is always needed
-  if (!stores.recipes.isInstalled(TODOS_RECIPE_ID)) {
-    console.log('Todos recipe is not installed, installing now...');
-    actions.recipe.install({ recipeId: TODOS_RECIPE_ID });
-  }
+  reaction(
+    () => stores.recipes.hasFinishedLoading,
+    (hasFinishedLoading) => {
+      if (hasFinishedLoading) {
+        if (!stores.recipes.isInstalled(TODOS_RECIPE_ID)) {
+          console.log('Todos recipe is not installed, installing now...');
+          actions.recipe.install({ recipeId: TODOS_RECIPE_ID });
+        }
+      }
+    },
+    {
+      fireImmediately: true,
+    },
+  );
 
   // Toggle todos feature
   reaction(

src/stores/RecipesStore.js

@@ -1,9 +1,9 @@
 import { action, computed, observable } from 'mobx';
 
-import Store from './lib/Store';
+import { matchRoute } from '../helpers/routing-helpers';
 import CachedRequest from './lib/CachedRequest';
 import Request from './lib/Request';
-import { matchRoute } from '../helpers/routing-helpers';
+import Store from './lib/Store';
 
 const debug = require('debug')('Franz:RecipeStore');
 
@@ -31,6 +31,10 @@ export default class RecipesStore extends Store {
     return this.all;
   }
 
+  @computed get hasFinishedLoading() {
+    return this.allRecipesRequest.wasExecuted;
+  }
+
   @computed get all() {
     return this.allRecipesRequest.execute().result || [];
   }