fix(App): Add security check before opening new window

meetfranz · Mar 31, 2022 · d36fa4c · d36fa4c
1 parent 68226bd
commit d36fa4c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/models/ServiceBrowserView.ts b/src/models/ServiceBrowserView.ts
@@ -12,6 +12,7 @@ import { buildMenuTpl } from '../electron/serviceContextMenuTemplate';
 import { IPC } from '../features/todos/constants';
 import { getRecipeDirectory, loadRecipeConfig } from '../helpers/recipe-helpers';
 import { isMac } from '../environment';
+import { isValidExternalURL } from '../helpers/url-helpers';
 
 const debug = require('debug')('Franz:Models:ServiceBrowserView');
 
@@ -252,7 +253,9 @@ export class ServiceBrowserView {
         } else if (disposition === 'background-tab' || disposition === 'foreground-tab') {
           action = 'deny';
 
-          shell.openExternal(url);
+          if (isValidExternalURL(url)) {
+            shell.openExternal(url);
+          }
         }
 
         return {