New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minimize setting check on close event #1038

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@imaginarny
Contributor

imaginarny commented Jul 22, 2018

Description

This change was a simple one-liner, just removed minimizeToSystemTray setting check from condition in close event. It's explained below.

Motivation and Context

It fixes issues #763 and #1006. Both describes a problem that you can't close a window until minimize to system tray is enabled. Which then, as a setting suggests, you loose a minimize to taskbar function. Therefore, minimization setting should not interfere with closing.

With provided code change, window will close as it should, according to "runInBackground" setting it will stay in system tray or will quit. Minimize function will not interfere with this functionality. When "minimize to system tray" enabled, it will only affect the window minimize function with overriding it to minimize to system tray instead, otherwise minimize function will stay intact.

How Has This Been Tested?

It was tested on Windows 10 and honestly, there is not much test. Close will close window, minimize will minimize to taskbar or system tray, according to its setting. As described above.

Screenshots:

Fixed behavior
franz1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project (run $ yarn lint).
@stale

This comment has been minimized.

stale bot commented Nov 16, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 16, 2018

@adlk adlk changed the base branch from master to develop Nov 16, 2018

@stale stale bot removed the wontfix label Nov 16, 2018

@adlk adlk self-requested a review Nov 16, 2018

@adlk

adlk approved these changes Nov 16, 2018

LGTM! Thanks for taking care of this 👍

@adlk adlk merged commit af9d356 into meetfranz:develop Nov 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@imaginarny

This comment has been minimized.

Contributor

imaginarny commented Nov 17, 2018

Great to see you back, Stefan. Thank you for merging this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment