Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove minimize setting check on close event #1038
This change was a simple one-liner, just removed minimizeToSystemTray setting check from condition in close event. It's explained below.
Motivation and Context
It fixes issues #763 and #1006. Both describes a problem that you can't close a window until minimize to system tray is enabled. Which then, as a setting suggests, you loose a minimize to taskbar function. Therefore, minimization setting should not interfere with closing.
With provided code change, window will close as it should, according to "runInBackground" setting it will stay in system tray or will quit. Minimize function will not interfere with this functionality. When "minimize to system tray" enabled, it will only affect the window minimize function with overriding it to minimize to system tray instead, otherwise minimize function will stay intact.
How Has This Been Tested?
It was tested on Windows 10 and honestly, there is not much test. Close will close window, minimize will minimize to taskbar or system tray, according to its setting. As described above.
Types of changes